OpenWF/SpaceNinjaServer
22
24
Fork 25
Code Issues 21 Pull Requests 1 Actions Packages Projects Releases Activity

feat(webui): edit suit invigorations #2478

Merged
Sainan merged 12 commits from nyaoouo/SpaceNinjaServer:ImplEditSuitInvigorationUpgradeController into main 2025-07-14 20:33:38 -07:00
Conversation 10 Commits 12 Files Changed 10 +7
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 89d0c472c4 - Show all commits

7
static/webui/index.html
View File

@ -476,6 +476,13 @@
<table class="table table-hover w-100">
<tbody id="crystals-list"></tbody>
</table>
</div>
Sainan marked this conversation as resolved Outdated
Sainan commented 2025-07-13 21:07:01 -07:00
Outdated
Review
Copy Link

Why is this inside of the archon crystals card and not its own card?

Why is this inside of the archon crystals card and not its own card?
nyaoouo commented 2025-07-14 05:07:31 -07:00
Outdated
Review
Copy Link

Because I didn't realize that you used path route first and then only controlled visibility based on url params...

Because I didn't realize that you used path route first and then only controlled visibility based on url params...
</div>
Sainan marked this conversation as resolved Outdated
Sainan commented 2025-07-12 21:16:43 -07:00
Outdated
Review
Copy Link

The oid is already in the query string. Be consistent.

The oid is already in the query string. Be consistent.
<div id="edit-suit-invigorations-card" class="card mb-3 d-none">
<h5 class="card-header">
edit suit invigorations
Sainan marked this conversation as resolved
Sainan commented 2025-07-14 05:09:30 -07:00
Review
Copy Link

All your strings should be added to the translation system. And let's not lowercase a title? 😒

All your strings should be added to the translation system. And let's not lowercase a title? 😒
nyaoouo commented 2025-07-14 05:28:46 -07:00
Review
Copy Link

because i just use my mobile phone to edit it =_=...

because i just use my mobile phone to edit it =_=...
Sainan commented 2025-07-14 07:02:15 -07:00
Review
Copy Link

Try coding on a PC. :)

Try coding on a PC. :)
</h5>
<div class="card-body">
Sainan marked this conversation as resolved
Sainan commented 2025-07-14 05:44:17 -07:00
Review
Copy Link

There are a few more strings here...

There are a few more strings here...
nyaoouo commented 2025-07-14 06:26:15 -07:00
Review
Copy Link

I don't know the exact translation of the attributes, so I'll just estimate it based on the key.

I don't know the exact translation of the attributes, so I'll just estimate it based on the key.
<form onsubmit="submitSuitInvigorationUpgrade(event)">
<div class="mb-3">
<label for="invigoration-offensive" class="form-label">Offensive Upgrade</label>