OpenWF/SpaceNinjaServer
22
24
Fork 25
Code Issues 20 Pull Requests 2 Actions Packages Projects Releases Activity

feat(webui): edit suit invigorations #2478

Merged
Sainan merged 12 commits from nyaoouo/SpaceNinjaServer:ImplEditSuitInvigorationUpgradeController into main 2025-07-14 20:33:38 -07:00
Conversation 10 Commits 12 Files Changed 10 +7 -3
7 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 870dfb377f - Show all commits

4
static/webui/index.html
View File

@ -479,9 +479,7 @@
</div> </div>
Sainan marked this conversation as resolved Outdated
Sainan commented 2025-07-13 21:07:01 -07:00
Outdated
Review
Copy Link

Why is this inside of the archon crystals card and not its own card?

Why is this inside of the archon crystals card and not its own card?
nyaoouo commented 2025-07-14 05:07:31 -07:00
Outdated
Review
Copy Link

Because I didn't realize that you used path route first and then only controlled visibility based on url params...

Because I didn't realize that you used path route first and then only controlled visibility based on url params...
</div> </div>
Sainan marked this conversation as resolved Outdated
Sainan commented 2025-07-12 21:16:43 -07:00
Outdated
Review
Copy Link

The oid is already in the query string. Be consistent.

The oid is already in the query string. Be consistent.
<div id="edit-suit-invigorations-card" class="card mb-3 d-none"> <div id="edit-suit-invigorations-card" class="card mb-3 d-none">
<h5 class="card-header"> <h5 class="card-header" data-loc="detailedView_editSuitInvigoration"></h5>
edit suit invigorations
</h5>
<div class="card-body"> <div class="card-body">
Sainan marked this conversation as resolved
Sainan commented 2025-07-14 05:09:30 -07:00
Review
Copy Link

All your strings should be added to the translation system. And let's not lowercase a title? 😒

All your strings should be added to the translation system. And let's not lowercase a title? 😒
nyaoouo commented 2025-07-14 05:28:46 -07:00
Review
Copy Link

because i just use my mobile phone to edit it =_=...

because i just use my mobile phone to edit it =_=...
Sainan commented 2025-07-14 07:02:15 -07:00
Review
Copy Link

Try coding on a PC. :)

Try coding on a PC. :)
<form onsubmit="submitSuitInvigorationUpgrade(event)"> <form onsubmit="submitSuitInvigorationUpgrade(event)">
<div class="mb-3"> <div class="mb-3">
Sainan marked this conversation as resolved
Sainan commented 2025-07-14 05:44:17 -07:00
Review
Copy Link

There are a few more strings here...

There are a few more strings here...
nyaoouo commented 2025-07-14 06:26:15 -07:00
Review
Copy Link

I don't know the exact translation of the attributes, so I'll just estimate it based on the key.

I don't know the exact translation of the attributes, so I'll just estimate it based on the key.

1
static/webui/translations/de.js
View File

@ -125,6 +125,7 @@ dict = {
detailedView_valenceBonusLabel: `Valenz-Bonus`, detailedView_valenceBonusLabel: `Valenz-Bonus`,
detailedView_valenceBonusDescription: `[UNTRANSLATED] You can set or remove the Valence Bonus from your weapon.`, detailedView_valenceBonusDescription: `[UNTRANSLATED] You can set or remove the Valence Bonus from your weapon.`,
detailedView_modularPartsLabel: `[UNTRANSLATED] Change Modular Parts`, detailedView_modularPartsLabel: `[UNTRANSLATED] Change Modular Parts`,
detailedView_editSuitInvigoration: `[UNTRANSLATED] Edit Suit Invigoration`,
mods_addRiven: `Riven hinzufügen`, mods_addRiven: `Riven hinzufügen`,
mods_fingerprint: `Fingerabdruck`, mods_fingerprint: `Fingerabdruck`,

1
static/webui/translations/en.js
View File

@ -124,6 +124,7 @@ dict = {
detailedView_valenceBonusLabel: `Valence Bonus`, detailedView_valenceBonusLabel: `Valence Bonus`,
detailedView_valenceBonusDescription: `You can set or remove the Valence Bonus from your weapon.`, detailedView_valenceBonusDescription: `You can set or remove the Valence Bonus from your weapon.`,
detailedView_modularPartsLabel: `Change Modular Parts`, detailedView_modularPartsLabel: `Change Modular Parts`,
detailedView_editSuitInvigoration: `Edit Suit Invigoration`,
mods_addRiven: `Add Riven`, mods_addRiven: `Add Riven`,
mods_fingerprint: `Fingerprint`, mods_fingerprint: `Fingerprint`,

1
static/webui/translations/es.js
View File

@ -125,6 +125,7 @@ dict = {
detailedView_valenceBonusLabel: `Bônus de Valência`, detailedView_valenceBonusLabel: `Bônus de Valência`,
detailedView_valenceBonusDescription: `Puedes establecer o quitar el bono de valencia de tu arma.`, detailedView_valenceBonusDescription: `Puedes establecer o quitar el bono de valencia de tu arma.`,
detailedView_modularPartsLabel: `[UNTRANSLATED] Change Modular Parts`, detailedView_modularPartsLabel: `[UNTRANSLATED] Change Modular Parts`,
detailedView_editSuitInvigoration: `[UNTRANSLATED] Edit Suit Invigoration`,
mods_addRiven: `Agregar Agrietado`, mods_addRiven: `Agregar Agrietado`,
mods_fingerprint: `Huella digital`, mods_fingerprint: `Huella digital`,

1
static/webui/translations/fr.js
View File

@ -125,6 +125,7 @@ dict = {
detailedView_valenceBonusLabel: `Bonus de Valence`, detailedView_valenceBonusLabel: `Bonus de Valence`,
detailedView_valenceBonusDescription: `[UNTRANSLATED] You can set or remove the Valence Bonus from your weapon.`, detailedView_valenceBonusDescription: `[UNTRANSLATED] You can set or remove the Valence Bonus from your weapon.`,
detailedView_modularPartsLabel: `[UNTRANSLATED] Change Modular Parts`, detailedView_modularPartsLabel: `[UNTRANSLATED] Change Modular Parts`,
detailedView_editSuitInvigoration: `[UNTRANSLATED] Edit Suit Invigoration`,
mods_addRiven: `Ajouter un riven`, mods_addRiven: `Ajouter un riven`,
mods_fingerprint: `Empreinte`, mods_fingerprint: `Empreinte`,

1
static/webui/translations/ru.js
View File

@ -125,6 +125,7 @@ dict = {
detailedView_valenceBonusLabel: `Бонус Валентности`, detailedView_valenceBonusLabel: `Бонус Валентности`,
detailedView_valenceBonusDescription: `Вы можете установить или убрать бонус валентности с вашего оружия.`, detailedView_valenceBonusDescription: `Вы можете установить или убрать бонус валентности с вашего оружия.`,
detailedView_modularPartsLabel: `Изменить Модульные Части`, detailedView_modularPartsLabel: `Изменить Модульные Части`,
detailedView_editSuitInvigoration: `[UNTRANSLATED] Edit Suit Invigoration`,
mods_addRiven: `Добавить Мод Разлома`, mods_addRiven: `Добавить Мод Разлома`,
mods_fingerprint: `Отпечаток`, mods_fingerprint: `Отпечаток`,

1
static/webui/translations/zh.js
View File

@ -125,6 +125,7 @@ dict = {
detailedView_valenceBonusLabel: `效价加成`, detailedView_valenceBonusLabel: `效价加成`,
detailedView_valenceBonusDescription: `您可以设置或移除武器上的效价加成.`, detailedView_valenceBonusDescription: `您可以设置或移除武器上的效价加成.`,
detailedView_modularPartsLabel: `更换部件`, detailedView_modularPartsLabel: `更换部件`,
detailedView_editSuitInvigoration: `[UNTRANSLATED] Edit Suit Invigoration`,
mods_addRiven: `添加裂罅MOD`, mods_addRiven: `添加裂罅MOD`,
mods_fingerprint: `印记`, mods_fingerprint: `印记`,