OpenWF/SpaceNinjaServer
28
29
Fork 35
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Activity

fix: add proper inventory slot costs #2435

Closed
Ghost wants to merge 1 commits from (deleted):slot-cost-fix into main
pull from: (deleted):slot-cost-fix
merge into: OpenWF:main
Conversation 4 Commits 1 Files Changed 1 +4 -5
Ghost commented 2025-07-07 13:11:59 -07:00
First-time contributor
Copy Link
No description provided.
Ghost added 1 commit 2025-07-07 13:11:59 -07:00
fix: add proper inventory slot costs
Some checks are pending
Build / build (pull_request) Blocked by required conditions
Details
c5f3b3b587
Ghost changed title from fix: add proper inventory slot costs to WIP: fix: add proper inventory slot costs 2025-07-07 13:15:41 -07:00
Ghost changed title from WIP: fix: add proper inventory slot costs to fix: add proper inventory slot costs 2025-07-07 13:16:02 -07:00
Ghost closed this pull request 2025-07-07 14:29:51 -07:00
Animan8000 commented 2025-07-08 00:26:52 -07:00
Contributor
Copy Link

?

?
VoltPrime commented 2025-07-08 05:18:04 -07:00
Contributor
Copy Link

Apologies for the confusion! I decided at the last second I didn't want to commit under my main alias. Reevaluating if I do actually want to get involved with this project or not, feel free to use the code in this PR if I don't make a new one though.

Apologies for the confusion! I decided at the last second I didn't want to commit under my main alias. Reevaluating if I do actually want to get involved with this project or not, feel free to use the code in this PR if I don't make a new one though.
Sainan commented 2025-07-08 05:25:17 -07:00
Owner
Copy Link

Feel free to open an issue for it, but as I see it, your patch is not quite accurate, as e.g. weapon slots would be bought 2 at a time.

Feel free to open an issue for it, but as I see it, your patch is not quite accurate, as e.g. weapon slots would be bought 2 at a time.
VoltPrime commented 2025-07-08 05:29:54 -07:00
Contributor
Copy Link

When I tested this it gave the correct amount of slots, but I was buying them from the inventory screen, not the market (U18 build I was using doesn't have slots in the market, not tested newer builds). I probably do need to give this another pass with better testing.

When I tested this it gave the correct amount of slots, but I was buying them from the inventory screen, not the market (U18 build I was using doesn't have slots in the market, not tested newer builds). I probably do need to give this another pass with better testing.
Some checks are pending
Build / build (pull_request) Blocked by required conditions
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2435
No description provided.
Delete Branch "(deleted):slot-cost-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?