OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 25 Pull Requests 2 Actions Packages Projects Releases Activity

fix: properly cap negative syndicate standing #2393

Merged
Sainan merged 2 commits from fix-cap into main 2025-07-03 11:08:58 -07:00
Conversation 3 Commits 2 Files Changed 1 +2 -2
Sainan commented 2025-07-02 14:25:28 -07:00
Owner
Copy Link

Closes #2388

Closes #2388
Sainan added 1 commit 2025-07-02 14:25:29 -07:00
fix: always apply negative standing cap
All checks were successful
Build / build (pull_request) Successful in 45s
Details
ef6e60fd11
Sainan added 1 commit 2025-07-02 16:49:06 -07:00
fix operation
All checks were successful
Build / build (pull_request) Successful in 1m23s
Details
1df5153a77
Sainan changed title from fix: always apply negative standing cap to fix: properly cap negative syndicate standing 2025-07-02 16:49:15 -07:00
likecheng210879 commented 2025-07-03 10:49:51 -07:00
First-time contributor
Copy Link

This fix only modified the TypeScript source code; the JavaScript files were not updated. At the same time, using the update batch file on the server is unable to synchronize updates and replace the fixed data.

This fix only modified the TypeScript source code; the JavaScript files were not updated. At the same time, using the update batch file on the server is unable to synchronize updates and replace the fixed data.
Sainan merged commit 41686aea88 into main 2025-07-03 11:08:58 -07:00
Sainan deleted branch fix-cap 2025-07-03 11:08:58 -07:00
Animan8000 commented 2025-07-03 11:13:55 -07:00
Contributor
Copy Link

This fix only modified the TypeScript source code; the JavaScript files were not updated. At the same time, using the update batch file on the server is unable to synchronize updates and replace the fixed data.

I am not sure what you exactly mean, but if you manually paste code (use git instead, I recommend) and then run the provided bat... no surprise that it won't work for you. You can grab the branch directly, do npm i, build & start and you don't have to worry about changes getting overwritten. Stuff is getting overwritten (for the most part) for a good reason, to update existing files correctly.

> This fix only modified the TypeScript source code; the JavaScript files were not updated. At the same time, using the update batch file on the server is unable to synchronize updates and replace the fixed data. I am not sure what you exactly mean, but if you manually paste code (use git instead, I recommend) and then run the provided bat... no surprise that it won't work for you. You can grab the branch directly, do npm i, build & start and you don't have to worry about changes getting overwritten. Stuff is getting overwritten (for the most part) for a good reason, to update existing files correctly.
likecheng210879 commented 2025-07-03 17:07:42 -07:00
First-time contributor
Copy Link

I am not sure what you exactly mean, but if you manually paste code (use git instead, I recommend) and then run the provided bat... no surprise that it won't work for you. You can grab the branch directly, do npm i, build & start and you don't have to worry about changes getting overwritten. Stuff is getting overwritten (for the most part) for a good reason, to update existing files correctly.

Thanks! The issue has been resolved now.

> I am not sure what you exactly mean, but if you manually paste code (use git instead, I recommend) and then run the provided bat... no surprise that it won't work for you. You can grab the branch directly, do npm i, build & start and you don't have to worry about changes getting overwritten. Stuff is getting overwritten (for the most part) for a good reason, to update existing files correctly. Thanks! The issue has been resolved now.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2393
No description provided.
Delete Branch "fix-cap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?