OpenWF/SpaceNinjaServer
21
23
Fork 24
Code Issues 24 Pull Requests 6 Actions Packages Projects Releases Activity

chore: continue execution if subsequent JSON.parse on config failed #2353

Merged
Sainan merged 1 commits from config-soft-fail into main 2025-06-29 11:54:21 -07:00
Conversation 0 Commits 1 Files Changed 2 +5 -3
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/configService.ts
View File

@ -103,11 +103,13 @@ export const config: IConfig = {
}; };
export const loadConfig = (): void => { export const loadConfig = (): void => {
const newConfig = JSON.parse(fs.readFileSync(configPath, "utf-8")) as IConfig;
// Set all values to undefined now so if the new config.json omits some fields that were previously present, it's correct in-memory. // Set all values to undefined now so if the new config.json omits some fields that were previously present, it's correct in-memory.
for (const key of Object.keys(config)) { for (const key of Object.keys(config)) {
// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/no-unsafe-member-access
(config as any)[key] = undefined; (config as any)[key] = undefined;
} }
Object.assign(config, JSON.parse(fs.readFileSync(configPath, "utf-8"))); Object.assign(config, newConfig);
}; };

4
src/services/configWatcherService.ts
View File

@ -14,8 +14,8 @@ chokidar.watch(configPath).on("change", () => {
try { try {
loadConfig(); loadConfig();
} catch (e) { } catch (e) {
logger.error("FATAL ERROR: Config failed to be reloaded: " + (e as Error).message); logger.error("Config changes were not applied: " + (e as Error).message);
process.exit(1); return;
} }
validateConfig(); validateConfig();
syncConfigWithDatabase(); syncConfigWithDatabase();