OpenWF/SpaceNinjaServer
21
23
Fork 24
Code Issues 22 Pull Requests 3 Actions Packages Projects Releases Activity

chore: continue execution if subsequent JSON.parse on config failed #2353

Merged
Sainan merged 1 commits from config-soft-fail into main 2025-06-29 11:54:21 -07:00
Conversation 0 Commits 1 Files Changed 2 +5 -3
Sainan commented 2025-06-29 10:45:50 -07:00
Owner
Copy Link

By calling JSON.parse before setting everything to undefined, we don't lose the old config in case of an error.

By calling JSON.parse before setting everything to undefined, we don't lose the old config in case of an error.
Sainan added 1 commit 2025-06-29 10:45:51 -07:00
chore: continue execution if subsequent JSON.parse on config failed
All checks were successful
Build / build (pull_request) Successful in 57s
Details
55308eda60 
By calling JSON.parse before setting everything to undefined, we don't lose the old config in case of an error.
Sainan merged commit 1a2d8ab19a into main 2025-06-29 11:54:21 -07:00
Sainan deleted branch config-soft-fail 2025-06-29 11:54:21 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2353
No description provided.
Delete Branch "config-soft-fail"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?