OpenWF/SpaceNinjaServer
19
22
Fork 23
Code Issues 32 Pull Requests 3 Actions Packages Projects Releases Activity

WIP: fix(webui): add steel path completion in completeAllMissions cheat #2288

Closed
AMelonInsideLemon wants to merge 3 commits from AMelonInsideLemon/SpaceNinjaServer:allMissions-bugfix into main
pull from: AMelonInsideLemon/SpaceNinjaServer:allMissions-bugfix
merge into: OpenWF:main
Conversation 3 Commits 3 Files Changed 1 +5 -2
AMelonInsideLemon commented 2025-06-25 13:09:04 -07:00
Contributor
Copy Link

Closes #2283

Closes #2283
AMelonInsideLemon added 2 commits 2025-06-25 13:09:04 -07:00 
Closes #2283
Update completeAllMissionsController.ts
All checks were successful
Build / build (pull_request) Successful in 1m19s
Details
873270ec8c
AMelonInsideLemon changed title from allMissions-bugfix to [AMelonInsideLemon] fix(webui): add steel path completion in completeAllMissions cheat 2025-06-25 13:09:22 -07:00
Sainan commented 2025-06-25 13:11:39 -07:00
Owner
Copy Link

I think there's also the possibility of Completes being 0 when a mission was started but aborted, right? I'd handle that as well.

I think there's also the possibility of `Completes` being 0 when a mission was started but aborted, right? I'd handle that as well.
AMelonInsideLemon added 1 commit 2025-06-25 13:18:42 -07:00
also check if Completes is valid
All checks were successful
Build / build (pull_request) Successful in 47s
Details
678e4d68e4
Sainan commented 2025-06-25 13:25:55 -07:00
Owner
Copy Link

Still not entirely correct; if Completes was 0, we need to give mission rewards.

Still not entirely correct; if `Completes` was 0, we need to give mission rewards.
AMelonInsideLemon commented 2025-06-25 13:42:57 -07:00
Author
Contributor
Copy Link

I think it's better to wait until #2289 get pushed before doing anything with that cheat

I think it's better to wait until #2289 get pushed before doing anything with that cheat
AMelonInsideLemon changed title from [AMelonInsideLemon] fix(webui): add steel path completion in completeAllMissions cheat to WIP: fix(webui): add steel path completion in completeAllMissions cheat 2025-06-25 13:43:11 -07:00
Sainan closed this pull request 2025-06-25 13:53:48 -07:00
All checks were successful
Build / build (pull_request) Successful in 47s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2288
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:allMissions-bugfix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?