OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 25 Pull Requests 2 Actions Packages Projects Releases Activity

feat: darvo deal #2261

Merged
Sainan merged 9 commits from darvo into main 2025-06-28 09:39:43 -07:00
Conversation 2 Commits 9 Files Changed 23 +374 -41
Sainan commented 2025-06-23 10:53:18 -07:00
Owner
Copy Link

Closes #2260

Closes #2260
Sainan force-pushed darvo from 24d778371f to 630d7471f2 2025-06-23 22:03:09 -07:00 Compare
Animan8000 commented 2025-06-24 07:00:44 -07:00
Contributor
Copy Link

Instead of No Daily Deal Purchase Limit, should it be called No Darvo Deal Purchase Limit instead? Since few other vendors IIRC also have their own daily deals/specials. Assuming this one is exclusively for Darvo (but isn't necessarily clear to an average user, that Darvo deals is meant with "Daily Deals").

Instead of `No Daily Deal Purchase Limit`, should it be called `No Darvo Deal Purchase Limit` instead? Since few other vendors IIRC also have their own daily deals/specials. Assuming this one is exclusively for Darvo (but isn't necessarily clear to an average user, that Darvo deals is meant with "Daily Deals").
Sainan force-pushed darvo from 630d7471f2 to c414bac827 2025-06-24 07:26:29 -07:00 Compare
Sainan force-pushed darvo from c414bac827 to cbc4d1bdf9 2025-06-25 20:25:46 -07:00 Compare
Sainan force-pushed darvo from d27934ab55 to 9ff1202a8f 2025-06-26 16:26:17 -07:00 Compare
Sainan commented 2025-06-27 20:26:34 -07:00
Author
Owner
Copy Link

Okay, I finally figured this out: The UsedDailyDeals field is cleaned up at daily reset, so this means it could take up to 23 hours from the deal expiring until it's no longer in the inventory. This also implies the same item not being on offer twice in a row.

Okay, I finally figured this out: The `UsedDailyDeals` field is cleaned up at daily reset, so this means it could take up to 23 hours from the deal expiring until it's no longer in the inventory. This also implies the same item not being on offer twice in a row.
Sainan force-pushed darvo from 6740b62cf1 to d56ab84164 2025-06-27 20:28:02 -07:00 Compare
Sainan force-pushed darvo from d56ab84164 to 29428ff9a8 2025-06-27 20:29:52 -07:00 Compare
Sainan added 1 commit 2025-06-27 20:42:12 -07:00
add darvo stock multiplier to webui
All checks were successful
Build / build (pull_request) Successful in 56s
Details
a75f7e0a5b
Sainan added 1 commit 2025-06-27 21:21:36 -07:00
faithful cleanup of UsedDailyDeals
All checks were successful
Build / build (pull_request) Successful in 56s
Details
cff01898b7
Sainan changed title from WIP: feat: darvo deal to feat: darvo deal 2025-06-27 21:22:49 -07:00
Sainan added 2 commits 2025-06-27 21:26:26 -07:00
respect noVendorPurchaseLimits for darvo deal as well
All checks were successful
Build / build (pull_request) Successful in 56s
Details
e090ce5307
Sainan merged commit ef3d3b92c7 into main 2025-06-28 09:39:43 -07:00
Sainan deleted branch darvo 2025-06-28 09:39:44 -07:00
Sainan referenced this issue from a commit 2025-06-28 09:39:44 -07:00
feat: darvo deal (#2261)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2261
No description provided.
Delete Branch "darvo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?