WIP: feat: darvo deal #2261

Draft

Sainan wants to merge 5 commits from darvo into main

pull from: darvo

merge into: OpenWF:main

Conversation 1 Commits 5 Files Changed 21 +335 -35

Sainan commented 2025-06-23 10:53:18 -07:00

Owner

Copy Link

Still need to verify if you're allowed to buy the same item multiple times if the offer has since expired.

Closes #2260

Still need to verify if you're allowed to buy the same item multiple times if the offer has since expired. Closes #2260

Sainan added 3 commits 2025-06-23 10:53:19 -07:00

add PurchaseSource enum c19780fc1d

simplify calls to updateCurrency in purchaseService 8d30cedf82

feat: daily deal 3bc08e0c19

Sainan added 1 commit 2025-06-23 10:57:19 -07:00

prettier 6104eeb524

Sainan added 1 commit 2025-06-23 12:25:16 -07:00

ensure stock is an int after multiplier 6fe0a42b13

Sainan added 1 commit 2025-06-23 13:12:30 -07:00

Add noDailyDealPurchaseLimit cheat aa2c71a206

Sainan added 1 commit 2025-06-23 19:37:53 -07:00

update comments 24d778371f

Sainan force-pushed darvo from 24d778371f to 630d7471f2 2025-06-23 22:03:09 -07:00 Compare

Animan8000 commented 2025-06-24 07:00:44 -07:00

Contributor

Copy Link

Instead of No Daily Deal Purchase Limit, should it be called No Darvo Deal Purchase Limit instead? Since few other vendors IIRC also have their own daily deals/specials. Assuming this one is exclusively for Darvo (but isn't necessarily clear to an average user, that Darvo deals is meant with "Daily Deals").

Instead of `No Daily Deal Purchase Limit`, should it be called `No Darvo Deal Purchase Limit` instead? Since few other vendors IIRC also have their own daily deals/specials. Assuming this one is exclusively for Darvo (but isn't necessarily clear to an average user, that Darvo deals is meant with "Daily Deals").

Sainan force-pushed darvo from 630d7471f2 to c414bac827 2025-06-24 07:26:29 -07:00 Compare

Sainan force-pushed darvo from c414bac827 to cbc4d1bdf9 2025-06-25 20:25:46 -07:00 Compare

Sainan added 1 commit 2025-06-26 16:24:49 -07:00

deduplicate static data by weighting it d27934ab55

Sainan force-pushed darvo from d27934ab55 to 9ff1202a8f 2025-06-26 16:26:17 -07:00 Compare

Sainan added 1 commit 2025-06-26 16:26:44 -07:00

prettier 6740b62cf1

All checks were successful

Hide all checks

Build / build (pull_request) Successful in 1m32s

Details

This pull request is marked as a work in progress.

This branch is out-of-date with the base branch

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin darvo:darvo

git checkout darvo

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

An existing implemention is incorrect

dependencies

Pull requests that update a dependency file

documentation

Improvements or additions to documentation

enhancement

New feature or request specific to the emulator

help wanted

Extra attention is needed

improvement

missing data

part of more major rehaul

Can't be worked on right now without merge conflicts later

pr'd for

Soon™

question

Further information is requested

unimplemented

you can do this

Considered easy enough for someone's first PR.

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2261

No description provided.