OpenWF/SpaceNinjaServer
16
13
Fork 17
Code Issues 38 Pull Requests 4 Actions Packages Projects Releases Activity

chore: don't fail missionInventoryUpdate on unknown items #2144

Merged
Sainan merged 1 commits from skip-unknown into main 2025-06-11 02:32:51 -07:00
Conversation 0 Commits 1 Files Changed 1 +2 -1
Sainan commented 2025-06-10 10:25:47 -07:00
Owner
Copy Link

It's possible we started a mission, deleted an item in the webui, and then finished it. The mission completion is still valid, we just can't update that item.

It's possible we started a mission, deleted an item in the webui, and then finished it. The mission completion is still valid, we just can't update that item.
Sainan added 1 commit 2025-06-10 10:25:47 -07:00
chore: don't fail missionInventoryUpdate on unknown items
All checks were successful
Build / build (pull_request) Successful in 43s
Details
Build / build (push) Successful in 2m26s
Details
9eff1b9032 
It's possible we started a mission, deleted an item in the webui, and then finished it. The mission completion is still valid, we just can't update that item.
Sainan merged commit 4823406229 into main 2025-06-11 02:32:51 -07:00
Sainan deleted branch skip-unknown 2025-06-11 02:32:52 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2144
No description provided.
Delete Branch "skip-unknown"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?