fix: handle multiple syndicate title increases at once #2139

Sainan · 2025-06-09T10:55:34-07:00

Sainan commented

2025-06-09 10:55:34 -07:00

Only really possible with nightwave afaik. Bug reported via #2138.

Sainan added 1 commit 2025-06-09 10:55:35 -07:00

fix: handle multiple syndicate title increases at once

Build / build (pull_request) Successful in 47s

Details

Build / build (push) Successful in 2m6s

Details

2c1ceba394

Only really possible with nightwave afaik

Sainan merged commit 1979b20f8c into main

2025-06-10 05:49:44 -07:00

Sainan deleted branch multi-rankup

2025-06-10 05:49:44 -07:00

Sainan referenced this issue from a commit

2025-06-10 05:49:45 -07:00

fix: handle multiple syndicate title increases at once (#2139)

nyaoouo commented

2025-06-12 01:36:21 -07:00

this impl broke SyndicateSacrifice initialze (from lv0 to lv0) (such as Cephalon Simaris)

if (levelIncrease < 1) { // <== should just let no lv up / only raise error when < 0
        throw new Error(`syndicate sacrifice needs an increase of at least 1`);
    }

and never handle initialize reward

 for (let level = oldLevel + 1; level <= data.SacrificeLevel; ++level) {  // <== level will be at least 1
        let sacrifice: ISyndicateSacrifice | undefined;
        if (level == 0) { // <== ???

this impl broke SyndicateSacrifice initialze (from lv0 to lv0) (such as Cephalon Simaris) ``` if (levelIncrease < 1) { // <== should just let no lv up / only raise error when < 0 throw new Error(`syndicate sacrifice needs an increase of at least 1`); } ``` and never handle initialize reward ``` for (let level = oldLevel + 1; level <= data.SacrificeLevel; ++level) { // <== level will be at least 1 let sacrifice: ISyndicateSacrifice | undefined; if (level == 0) { // <== ??? ```

nyaoouo referenced this pull request

2025-06-12 01:56:36 -07:00

fix error when initialize calling syndicateSacrifice #2148

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2139