OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 4 Actions Packages Projects Releases Activity

fix: weapon seed's low dword being sign extended #1914

Merged
Sainan merged 1 commits from lodword-fix into main 2025-04-29 12:28:01 -07:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
Sainan commented 2025-04-29 04:08:42 -07:00
Owner
Copy Link

JavaScript's semantics here are incredibly stupid, but basically if the initial DWORD's high WORD's MSB is true, the number would become negative after the shift left by 16. Then when ORing it with the highDword, the initial DWORD would be sign-extended to a QWORD, meaning the high DWORD would become all 1s, basically cancelling out the entire OR operation.

JavaScript's semantics here are incredibly stupid, but basically if the initial DWORD's high WORD's MSB is true, the number would become negative after the shift left by 16. Then when ORing it with the highDword, the initial DWORD would be sign-extended to a QWORD, meaning the high DWORD would become all 1s, basically cancelling out the entire OR operation.
Sainan added 1 commit 2025-04-29 04:08:42 -07:00
fix: weapon seed's low dword being sign extended
All checks were successful
Build / build (push) Successful in 1m42s
Details
Build / build (pull_request) Successful in 1m7s
Details
ce37b736b7 
JavaScript's semantics here are incredibly stupid, but basically if the initial DWORD's high WORD's MSB is true, the number would become negative after the shift left by 16. Then when ORing it with the highDword, the initial DWORD would be sign-extended to a QWORD, meaning the high DWORD would become all 1s, basically cancelling out the entire OR operation.
Sainan merged commit 9468768947 into main 2025-04-29 12:28:01 -07:00
Sainan deleted branch lodword-fix 2025-04-29 12:28:01 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1914
No description provided.
Delete Branch "lodword-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?