OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 3 Actions Packages Projects Releases Activity

chore: removing unnecessary entries in allScans.json #1903

Merged
Sainan merged 1 commits from Animan8000/SpaceNinjaServer:animan8000-patch-1 into main 2025-04-28 03:36:40 -07:00
Conversation 0 Commits 1 Files Changed 1 +1 -3
Animan8000 commented 2025-04-28 03:25:37 -07:00
Contributor
Copy Link

These two entries were previously only added during a bug where random enemies and objects would be considered "unscanned". However, that bug was fixed (by #1875), and removing these two doesn't seem to have any negative effect. You can force spawn the two listed enemies in mission and they are being considered "scanned" in advance, even if they are removed from the json file in advance.

{40F222D7-96AB-4BEB-85DF-AE7C61E6DFA5}.png
These two entries were previously only added during a bug where random enemies and objects would be considered "unscanned". However, that bug was fixed (by #1875), and removing these two doesn't seem to have any negative effect. You can force spawn the two listed enemies in mission and they are being considered "scanned" in advance, even if they are removed from the json file in advance. <img width="1440" alt="{40F222D7-96AB-4BEB-85DF-AE7C61E6DFA5}.png" src="attachments/16d55eb7-2476-4964-9ff2-dfd2a43814b2">
{40F222D7-96AB-4BEB-85DF-AE7C61E6DFA5}.png
2.9 MiB
Animan8000 added 1 commit 2025-04-28 03:25:37 -07:00
chore: removing unnecessary entries in allScans.json
All checks were successful
Build / build (pull_request) Successful in 1m32s
Details
ba32aa03f1
Sainan merged commit 4e3a2e17ee into main 2025-04-28 03:36:40 -07:00
Sainan deleted branch animan8000-patch-1 2025-04-28 03:36:40 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1903
No description provided.
Delete Branch "Animan8000/SpaceNinjaServer:animan8000-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?