OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 3 Actions Packages Projects Releases Activity

feat: conquest research points #1796

Merged
Sainan merged 5 commits from janisslsm/SpaceNinjaServer:conquest-points into conquest-progress 2025-04-22 15:23:29 -07:00
Conversation 2 Commits 5 Files Changed 3 +62 -13
janisslsm commented 2025-04-22 14:32:53 -07:00
Contributor
Copy Link
No description provided.
janisslsm added 1 commit 2025-04-22 14:32:54 -07:00
feat: conquest research points
Some checks failed
Build / build (pull_request) Failing after 42s
Details
568b2913ba
janisslsm added 1 commit 2025-04-22 14:35:27 -07:00
prettify
All checks were successful
Build / build (pull_request) Successful in 1m27s
Details
7e23810cad
Sainan commented 2025-04-22 14:45:36 -07:00
Owner
Copy Link

I think this logic should be in addMissionRewards just like everything else here. ConquestCompletedMissionsCount could maybe be an additional return field.

I think this logic should be in `addMissionRewards` just like everything else here. `ConquestCompletedMissionsCount` could maybe be an additional return field.
janisslsm added 1 commit 2025-04-22 15:10:08 -07:00
move archimedea handling to addMissionRewards
Some checks failed
Build / build (pull_request) Failing after 1m10s
Details
64de3e2bd5
janisslsm added 1 commit 2025-04-22 15:15:21 -07:00
get rid of unused import
All checks were successful
Build / build (pull_request) Successful in 1m33s
Details
e563b466a0
Sainan reviewed 2025-04-22 15:19:01 -07:00
src/controllers/api/missionInventoryUpdateController.ts
@ -96,1 +94,3 @@
res.json(response);
AffiliationMods,
ConquestCompletedMissionsCount
});
Sainan commented 2025-04-22 15:19:01 -07:00
Owner
Copy Link

I'd add satisfies IMissionInventoryUpdateResponse

I'd add `satisfies IMissionInventoryUpdateResponse`
Sainan marked this conversation as resolved
janisslsm added 1 commit 2025-04-22 15:22:47 -07:00
satisfies IMissionInventoryUpdateResponse
All checks were successful
Build / build (pull_request) Successful in 1m29s
Details
4b0e3f0337
Sainan merged commit 5da66a1b3b into conquest-progress 2025-04-22 15:23:29 -07:00
Sainan deleted branch conquest-points 2025-04-22 15:23:29 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1796
No description provided.
Delete Branch "janisslsm/SpaceNinjaServer:conquest-points"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?