OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat: send WiTW email when completing The New War or Heart of Deimos #1749

Merged
Sainan merged 1 commits from witw into main 2025-04-20 16:10:45 -07:00
Conversation 2 Commits 1 Files Changed 1 +21
Sainan commented 2025-04-19 19:13:57 -07:00
Owner
Copy Link

At completion of either of the quests, check if the other has been completed, and if so, unlock WiTW.

Closes #1748

At completion of either of the quests, check if the other has been completed, and if so, unlock WiTW. Closes #1748
Sainan added 1 commit 2025-04-19 19:13:58 -07:00
feat: send WiTW email when completing The New War or Heart of Deimos
All checks were successful
Build / build (push) Successful in 59s
Details
Build / build (pull_request) Successful in 1m28s
Details
8f724ba90f 
At completion of either of the quests, check if the other has been completed, and if so, unlock WiTW.
VampireKitten commented 2025-04-20 06:00:21 -07:00
Contributor
Copy Link

The check for Heart of Deimos is unnecessary, as you must complete Heart of Deimos to access Jupiter, which means it's impossible to reach a game state where you have completed New War but not Heart of Deimos, unless you are using the WebUI to skip mission nodes and story quests altogether.

The check for Heart of Deimos is unnecessary, as you must complete Heart of Deimos to access Jupiter, which means it's impossible to reach a game state where you have completed New War but not Heart of Deimos, unless you are using the WebUI to skip mission nodes and story quests altogether.
Sainan commented 2025-04-20 07:51:28 -07:00
Author
Owner
Copy Link

Well, the codex lists both as prerequisites, so...

Well, the codex lists both as prerequisites, so...
Sainan merged commit 218df461e1 into main 2025-04-20 16:10:45 -07:00
Sainan deleted branch witw 2025-04-20 16:10:45 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1749
No description provided.
Delete Branch "witw"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?