OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

chore(webui): respect user's light mode preference #1727

Closed
Sainan wants to merge 1 commits from flashbang into main
pull from: flashbang
merge into: OpenWF:main
Conversation 2 Commits 1 Files Changed 1 +4
Sainan commented 2025-04-18 12:02:58 -07:00
Owner
Copy Link

Closes #1721

Closes #1721
Sainan added 1 commit 2025-04-18 12:02:58 -07:00
chore(webui): respect user's light mode preference
All checks were successful
Build / build (push) Successful in 1m27s
Details
Build / build (pull_request) Successful in 1m26s
Details
c67ee191e2
Animan8000 commented 2025-04-19 02:13:35 -07:00
Contributor
Copy Link

There should be a way in WebUI to allow the user to manually change the theme (White, Dark, System-aware), like maybe left next to the language selector. There is a good reason for that actually (aside that a user might prefer a mix for whatever reason): If you install Windows and you don't activate it yet (maybe no key), you will be stuck with White Mode and the Settings App won't allow you to change to Dark Mode (there's workarounds but that's not the point, the WebUI should give the user the freedom to manually change, if they happen to wish that). Aside of that, system-aware should certainly be the default selected option, but a selector would be desired as well.

image.png

image.png

There should be a way in WebUI to allow the user to manually change the theme (White, Dark, System-aware), like maybe left next to the language selector. There is a good reason for that actually (aside that a user might prefer a mix for whatever reason): If you install Windows and you don't activate it yet (maybe no key), you will be stuck with White Mode and the Settings App won't allow you to change to Dark Mode (there's workarounds but that's not the point, the WebUI should give the user the freedom to manually change, if they happen to wish that). Aside of that, system-aware should certainly be the default selected option, but a selector would be desired as well. <img width="572" alt="image.png" src="attachments/900acb49-b8c7-4100-a94e-dfa1fff82ab5"> ![image.png](/attachments/3e7f94e9-b24f-491b-a68c-f6d733045eb6)
image.png
20 KiB
image.png
272 KiB
Sainan commented 2025-04-19 08:55:17 -07:00
Author
Owner
Copy Link

Not worth the effort, then.

Not worth the effort, then.
Sainan closed this pull request 2025-04-19 08:55:17 -07:00
Sainan deleted branch flashbang 2025-04-19 08:55:25 -07:00
All checks were successful
Build / build (push) Successful in 1m27s
Details
Build / build (pull_request) Successful in 1m26s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1727
No description provided.
Delete Branch "flashbang"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?