OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 46 Pull Requests 1 Actions Packages Projects Releases Activity

fix: duplicated code in getShipController #158

Merged
Sainan merged 1 commits from fix-dup into main 2024-05-09 07:07:19 -07:00
Conversation 0 Commits 1 Files Changed 2 +2 -11
2 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/controllers/api/getShipController.ts
View File

@ -2,6 +2,7 @@ import { RequestHandler } from "express";
import config from "@/config.json";
import allShipFeatures from "@/static/fixed_responses/allShipFeatures.json";
import { parseString } from "@/src/helpers/general";
import { getPersonalRooms } from "@/src/services/personalRoomsService";
import { getShip } from "@/src/services/shipService";
import { PersonalRooms } from "@/src/models/personalRoomsModel";
import { Loadout } from "@/src/models/inventoryModels/loadoutModel";
@ -48,13 +49,3 @@ export const getLoadout = async (accountId: string) => {
return loadout;
};
export const getPersonalRooms = async (accountId: string) => {
const personalRooms = await PersonalRooms.findOne({ personalRoomsOwnerId: accountId });
if (!personalRooms) {
logger.error(`personal rooms not found for account ${accountId}`);
throw new Error("personal rooms not found");
}
return personalRooms;
};

2
src/controllers/api/setActiveShipController.ts
View File

@ -1,4 +1,4 @@
import { getPersonalRooms } from "@/src/controllers/api/getShipController";
import { getPersonalRooms } from "@/src/services/personalRoomsService";
import { parseString } from "@/src/helpers/general";
import { RequestHandler } from "express";
import { Types } from "mongoose";