OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 22 Pull Requests Actions Packages Projects Releases Activity

feat: bounty standing reward #1556

Merged
Sainan merged 12 commits from AMelonInsideLemon/SpaceNinjaServer:bounty-standing-rewards into main 2025-04-12 06:13:45 -07:00
Conversation 4 Commits 12 Files Changed 6 +149 -70
AMelonInsideLemon commented 2025-04-10 17:24:39 -07:00
Member
Copy Link

Re #388
I think this only missing Field Bounties and Arcana Isolation Vault

Re #388 I think this only missing `Field Bounties` and `Arcana Isolation Vault`
AMelonInsideLemon added 1 commit 2025-04-10 17:24:40 -07:00
feat: bounty standing reward
All checks were successful
Build / build (pull_request) Successful in 41s
Details
9a37b9ed85 
Re #388
I think this only missing `Field Bounties` and `Arcana Isolation Vault`
AMelonInsideLemon added 1 commit 2025-04-10 17:39:19 -07:00
Update missionInventoryUpdateService.ts
All checks were successful
Build / build (pull_request) Successful in 1m24s
Details
3bcf719c81
AMelonInsideLemon added 1 commit 2025-04-10 18:39:54 -07:00
Heists/HeistProfitTakerBountyOne: give standing only on last stage
All checks were successful
Build / build (pull_request) Successful in 1m26s
Details
ed3d836417
Sainan commented 2025-04-11 06:57:18 -07:00
Owner
Copy Link

Your PR has merge conflicts now (very predictably).

Your PR has merge conflicts now (very predictably).
AMelonInsideLemon added 5 commits 2025-04-11 11:38:17 -07:00 
Re #388
I think this only missing `Field Bounties` and `Arcana Isolation Vault`
AMelonInsideLemon commented 2025-04-11 11:40:04 -07:00
Author
Member
Copy Link

I think its poorly but resolved

I think its poorly but resolved
Sainan commented 2025-04-11 11:43:47 -07:00
Owner
Copy Link

Looks good, but this new addStanding function could maybe be reused in syndicateStandingBonusController and possibly also fishmongerController to avoid the code duplication?

Looks good, but this new `addStanding` function could maybe be reused in syndicateStandingBonusController and possibly also fishmongerController to avoid the code duplication?
AMelonInsideLemon commented 2025-04-11 11:53:58 -07:00
Author
Member
Copy Link

I think yeah

I think yeah
AMelonInsideLemon added 1 commit 2025-04-11 12:00:29 -07:00
use addStanding in more places
All checks were successful
Build / build (pull_request) Successful in 1m24s
Details
8191d51847
AMelonInsideLemon added 1 commit 2025-04-11 12:10:16 -07:00
Update fishmongerController.ts
All checks were successful
Build / build (pull_request) Successful in 1m24s
Details
3b2fcaf632
AMelonInsideLemon added 1 commit 2025-04-11 12:27:52 -07:00
Update missionInventoryUpdateService.ts
All checks were successful
Build / build (pull_request) Successful in 40s
Details
afa5057c97
AMelonInsideLemon added 1 commit 2025-04-11 12:32:23 -07:00
give Hunts/AllTeralystsHunt reward only on last stage
All checks were successful
Build / build (pull_request) Successful in 1m25s
Details
56160db80c
Sainan merged commit 946f3129b8 into main 2025-04-12 06:13:45 -07:00
Sainan deleted branch bounty-standing-rewards 2025-04-12 06:13:45 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1556
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:bounty-standing-rewards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?