OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

chore: don't use ? for leaderboardService parameters #1551

Merged
Sainan merged 1 commits from leaderboard-refactor into main 2025-04-11 06:54:48 -07:00
Conversation 0 Commits 1 Files Changed 2 +6 -5
Sainan commented 2025-04-10 14:04:14 -07:00
Owner
Copy Link

This means the argument can be omitted when we really mean that it can be undefined — but we still want it to be explicitly given.

This means the argument can be omitted when we really mean that it can be undefined — but we still want it to be explicitly given.
Sainan added 1 commit 2025-04-10 14:04:15 -07:00
chore: don't use ? for leaderboardService parameters
All checks were successful
Build / build (push) Successful in 41s
Details
Build / build (pull_request) Successful in 1m26s
Details
f5dc61018a 
This means the argument can be omitted when we really mean that it can be undefined — but we still want it to be explicitly given.
Sainan merged commit 5149d0e382 into main 2025-04-11 06:54:48 -07:00
Sainan deleted branch leaderboard-refactor 2025-04-11 06:54:48 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1551
No description provided.
Delete Branch "leaderboard-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?