OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

fix: clamp ItemCount within 32-bit integer range #1432

Merged
Sainan merged 1 commits from clamp-count into main 2025-04-02 13:20:06 -07:00
Conversation 0 Commits 1 Files Changed 1 +10
Sainan commented 2025-04-02 05:22:29 -07:00
Owner
Copy Link

It seems the game uses 32-bit ints for these values on the C++ side before passing them on to Lua where they become floats. This would cause the game to have overflow/underflow semantics when receiving values outside of these bounds.

It seems the game uses 32-bit ints for these values on the C++ side before passing them on to Lua where they become floats. This would cause the game to have overflow/underflow semantics when receiving values outside of these bounds.
Sainan added 1 commit 2025-04-02 05:22:29 -07:00
fix: clamp ItemCount within 32-bit integer range
All checks were successful
Build / build (20) (push) Successful in 41s
Details
Build / build (18) (push) Successful in 1m15s
Details
Build / build (18) (pull_request) Successful in 42s
Details
Build / build (22) (push) Successful in 1m9s
Details
Build / build (20) (pull_request) Successful in 1m14s
Details
Build / build (22) (pull_request) Successful in 1m9s
Details
ddf7a658ca 
It seems the game uses 32-bit ints for these values on the C++ side before passing them on to Lua where they become floats. This would cause the game to have overflow/underflow semantics when receiving values outside of these bounds.
Sainan merged commit 2173bdb8b8 into main 2025-04-02 13:20:06 -07:00
Sainan deleted branch clamp-count 2025-04-02 13:20:06 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1432
No description provided.
Delete Branch "clamp-count"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?