OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

fix: detect kuva weapons more reliably #1388

Merged
Sainan merged 1 commits from kuva-fix into main 2025-03-30 09:58:44 -07:00
Conversation 2 Commits 1 Files Changed 1 +1 -4
Sainan commented 2025-03-30 08:44:21 -07:00
Owner
Copy Link

it seems not all of them have the InnateDamageRandomMod or even VT_KUVA so just assuming that any weapon with max rank 40 that's not the ballas sword needs it

Closes #1387

it seems not all of them have the InnateDamageRandomMod or even VT_KUVA so just assuming that any weapon with max rank 40 that's not the ballas sword needs it Closes #1387
Sainan added 1 commit 2025-03-30 08:44:22 -07:00
fix: detect kuva weapons more reliably
All checks were successful
Build / build (20) (push) Successful in 43s
Details
Build / build (22) (push) Successful in 1m17s
Details
Build / build (18) (push) Successful in 1m22s
Details
Build / build (20) (pull_request) Successful in 43s
Details
Build / build (18) (pull_request) Successful in 1m21s
Details
Build / build (22) (pull_request) Successful in 1m22s
Details
1e1d6b853f 
it seems not all of them have the InnateDamageRandomMod or even VT_KUVA so just assuming that any weapon with max rank 40 that's not the ballas sword needs it
VampireKitten commented 2025-03-30 08:57:38 -07:00
Contributor
Copy Link

Necramechs also go up to rank 40, but they don't get pulled by weapon., do they?

Necramechs also go up to rank 40, but they don't get pulled by `weapon.`, do they?
Sainan commented 2025-03-30 08:58:25 -07:00
Author
Owner
Copy Link

Yeah, necramechs aren't weapons.

Yeah, necramechs aren't weapons.
Sainan merged commit fccdbf4a8e into main 2025-03-30 09:58:44 -07:00
Sainan deleted branch kuva-fix 2025-03-30 09:58:44 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1388
No description provided.
Delete Branch "kuva-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?