OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

chore: accurate infested pet traits #1356

Merged
Sainan merged 1 commits from AMelonInsideLemon/SpaceNinjaServer:infested-colors into main 2025-03-28 06:49:30 -07:00
Conversation 2 Commits 1 Files Changed 1 +73 -38
AMelonInsideLemon commented 2025-03-28 05:35:34 -07:00
Contributor
Copy Link
No description provided.
AMelonInsideLemon added 1 commit 2025-03-28 05:35:35 -07:00
chore: accurate infested pet traits
All checks were successful
Build / build (18) (pull_request) Successful in 43s
Details
Build / build (22) (pull_request) Successful in 1m16s
Details
Build / build (20) (pull_request) Successful in 1m21s
Details
b8eb1f715a
Sainan reviewed 2025-03-28 05:37:52 -07:00
src/controllers/api/modularWeaponCraftingController.ts
@ -81,0 +111,4 @@
if (!traits) {
throw new Error(`unknown KubrowPets type: ${data.WeaponType}`);
}
Sainan commented 2025-03-28 05:37:52 -07:00
Owner
Copy Link

This isn't needed because of modularWeaponTypes

This isn't needed because of modularWeaponTypes
AMelonInsideLemon commented 2025-03-28 05:40:13 -07:00
Author
Contributor
Copy Link

then something like that will be okay?

DominantTraits: traits!,
RecessiveTraits: traits!
then something like that will be okay? ``` DominantTraits: traits!, RecessiveTraits: traits! ```
Sainan commented 2025-03-28 05:41:39 -07:00
Owner
Copy Link

TypeScript assumes indexing will always succeed, you do not need !

TypeScript assumes indexing will always succeed, you do not need !
AMelonInsideLemon commented 2025-03-28 05:43:20 -07:00
Author
Contributor
Copy Link

on my side it throws Type 'undefined' is not assignable to type 'ITraits' error

on my side it throws `Type 'undefined' is not assignable to type 'ITraits'` error
Sainan commented 2025-03-28 05:45:39 -07:00
Owner
Copy Link

Hmm, then leave it as-is, I guess.

Hmm, then leave it as-is, I guess.
Sainan marked this conversation as resolved
Sainan approved these changes 2025-03-28 05:45:54 -07:00
Sainan merged commit 3a904753f2 into main 2025-03-28 06:49:30 -07:00
Sainan deleted branch infested-colors 2025-03-28 06:49:30 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1356
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:infested-colors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?