OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 42 Pull Requests 2 Actions Packages Projects Releases Activity

feat(leaderboard): missions & guilds leaderboard #1338

Merged
Sainan merged 3 commits from AMelonInsideLemon/SpaceNinjaServer:missions-leaderbord into main 2025-03-26 14:21:22 -07:00
Conversation 7 Commits 3 Files Changed 5 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 5c4881a340 - Show all commits

3
src/services/statsService.ts
View File

@ -317,7 +317,8 @@ export const updateStats = async (accountOwnerId: string, payload: IStatsUpdate)
race,
accountOwnerId,
payload.displayName,
highScore
highScore,
payload.guildId
Sainan marked this conversation as resolved Outdated
Sainan commented 2025-03-26 14:06:08 -07:00
Outdated
Review
Copy Link

You should revert this change, it is not correct or faithful.

You should revert this change, it is not correct or faithful.
AMelonInsideLemon commented 2025-03-26 14:09:49 -07:00
Outdated
Review
Copy Link

K-drive races have clans leaderboard in ESC menu

K-drive races have clans leaderboard in ESC menu
Sainan commented 2025-03-26 14:11:22 -07:00
Outdated
Review
Copy Link

But not for clan tiers I mean. Also, the guildId is undefined in the upload request for K-Drive races, so this is wrong either way.

But not for clan tiers I mean. Also, the `guildId` is undefined in the upload request for K-Drive races, so this is wrong either way.
AMelonInsideLemon commented 2025-03-26 14:17:23 -07:00
Outdated
Review
Copy Link

They have buttons for that leaderboards but seams missing guildId is bug image.pngimage.png

They have buttons for that leaderboards but seams missing `guildId` is bug ![image.png](/attachments/dd4f0163-cfd0-4567-8b29-f9add939f7a2)![image.png](/attachments/6ea7747b-2424-49a6-b720-5a76d7dc30c6)
image.png
3.3 MiB
image.png
3.2 MiB
Sainan commented 2025-03-26 14:18:44 -07:00
Outdated
Review
Copy Link

Yeah exactly. Then again, maybe the bug is in the way the client sends the request...

Yeah exactly. Then again, maybe the bug is in the way the client sends the request...
);
}