OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat(leaderboard): missions & guilds leaderboard #1338

Merged
Sainan merged 3 commits from AMelonInsideLemon/SpaceNinjaServer:missions-leaderbord into main 2025-03-26 14:21:22 -07:00
Conversation 7 Commits 3 Files Changed 5 +59 -11
AMelonInsideLemon commented 2025-03-26 13:59:06 -07:00
Contributor
Copy Link

Re #1165

Re #1165
AMelonInsideLemon added 1 commit 2025-03-26 13:59:06 -07:00
feat(leaderboard): missions & guilds leaderboard
All checks were successful
Build / build (22) (pull_request) Successful in 37s
Details
Build / build (18) (pull_request) Successful in 1m13s
Details
Build / build (20) (pull_request) Successful in 1m23s
Details
7bd8eccdf7 
Re #1165
Sainan approved these changes 2025-03-26 14:01:54 -07:00
Sainan commented 2025-03-26 14:02:31 -07:00
Owner
Copy Link

Wouldn't you say this closes #1165 or is still something missing?

Wouldn't you say this closes #1165 or is still something missing?
Sainan reviewed 2025-03-26 14:06:08 -07:00
src/services/statsService.ts Outdated
@ -309,2 +319,3 @@
payload.displayName,
highScore
highScore,
payload.guildId
Sainan commented 2025-03-26 14:06:08 -07:00
Owner
Copy Link

You should revert this change, it is not correct or faithful.

You should revert this change, it is not correct or faithful.
AMelonInsideLemon commented 2025-03-26 14:09:49 -07:00
Author
Contributor
Copy Link

K-drive races have clans leaderboard in ESC menu

K-drive races have clans leaderboard in ESC menu
Sainan commented 2025-03-26 14:11:22 -07:00
Owner
Copy Link

But not for clan tiers I mean. Also, the guildId is undefined in the upload request for K-Drive races, so this is wrong either way.

But not for clan tiers I mean. Also, the `guildId` is undefined in the upload request for K-Drive races, so this is wrong either way.
AMelonInsideLemon commented 2025-03-26 14:17:23 -07:00
Author
Contributor
Copy Link

They have buttons for that leaderboards but seams missing guildId is bug image.pngimage.png

They have buttons for that leaderboards but seams missing `guildId` is bug ![image.png](/attachments/dd4f0163-cfd0-4567-8b29-f9add939f7a2)![image.png](/attachments/6ea7747b-2424-49a6-b720-5a76d7dc30c6)
image.png
3.3 MiB
image.png
3.2 MiB
Sainan commented 2025-03-26 14:18:44 -07:00
Owner
Copy Link

Yeah exactly. Then again, maybe the bug is in the way the client sends the request...

Yeah exactly. Then again, maybe the bug is in the way the client sends the request...
Sainan marked this conversation as resolved
AMelonInsideLemon commented 2025-03-26 14:08:20 -07:00
Author
Contributor
Copy Link

There is PVP, Operations and something related to Octavia's Anthem quest missing, but i think this is more related to stats. So maybe yeah this closes #1165

There is PVP, Operations and something related to Octavia's Anthem quest missing, but i think this is more related to stats. So maybe yeah this closes #1165
AMelonInsideLemon added 1 commit 2025-03-26 14:18:30 -07:00
revert guild leaderboard for races
All checks were successful
Build / build (18) (pull_request) Successful in 43s
Details
Build / build (20) (pull_request) Successful in 1m20s
Details
Build / build (22) (pull_request) Successful in 40s
Details
81c3340cd5
Sainan added 1 commit 2025-03-26 14:21:04 -07:00
revert 81c3340cd57f5864c433570c1fd72fb07cf537f6
All checks were successful
Build / build (20) (pull_request) Successful in 40s
Details
Build / build (22) (pull_request) Successful in 1m9s
Details
Build / build (18) (pull_request) Successful in 1m33s
Details
5c4881a340 
revert revert guild leaderboard for races
Sainan merged commit 049f709713 into main 2025-03-26 14:21:22 -07:00
Sainan deleted branch missions-leaderbord 2025-03-26 14:21:23 -07:00
VampireKitten commented 2025-03-26 14:23:00 -07:00
Contributor
Copy Link

There is PVP, Operations and something related to Octavia's Anthem quest missing, but i think this is more related to stats. So maybe yeah this closes #1165

The Octavia's Anthem thing is that you can replay the Cephalon Weave portion where you play DDR against Hunhow in Cephalon Suda's... memories? If you go to Suda's room in the relay, there's a floating bot to replay that section of the quest after you complete it.

> There is PVP, Operations and something related to Octavia's Anthem quest missing, but i think this is more related to stats. So maybe yeah this closes #1165 The Octavia's Anthem thing is that you can replay the Cephalon Weave portion where you play DDR against Hunhow in Cephalon Suda's... memories? If you go to Suda's room in the relay, there's a floating bot to replay that section of the quest after you complete it.
AMelonInsideLemon commented 2025-03-26 14:24:30 -07:00
Author
Contributor
Copy Link

Why is there even a leaderboard for that?

Why is there even a leaderboard for that?
VampireKitten commented 2025-03-26 14:30:43 -07:00
Contributor
Copy Link

I... have no idea.

But there's even a speedrun leaderboard for it. Someone even set a world record a month ago.

I... have no idea. But there's even a [speedrun leaderboard](https://www.speedrun.com/wf/leaderboards?h=Incident_Archive_2318-H-Solo&x=l_y9mx8o1w-rklqexq2) for it. Someone even set a world record a month ago.
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1338
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:missions-leaderbord"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?