OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat(import): additional fields #1305

Merged
Sainan merged 3 commits from AMelonInsideLemon/SpaceNinjaServer:importer-new-fields into main 2025-03-23 13:33:27 -07:00
Conversation 7 Commits 3 Files Changed 4 +160 -71
AMelonInsideLemon commented 2025-03-23 08:42:24 -07:00
Contributor
Copy Link
No description provided.
AMelonInsideLemon added 1 commit 2025-03-23 08:42:25 -07:00
feat(import): additional fields
All checks were successful
Build / build (18) (pull_request) Successful in 46s
Details
Build / build (22) (pull_request) Successful in 1m11s
Details
Build / build (20) (pull_request) Successful in 1m16s
Details
811a84ea56
Sainan reviewed 2025-03-23 08:44:08 -07:00
src/models/inventoryModels/inventoryModel.ts Outdated
@ -1267,2 +1267,2 @@
CrewShipSalvagedWeaponSkins: [Schema.Types.Mixed],
CrewShipSalvagedWeapons: [Schema.Types.Mixed],
CrewShipSalvagedWeaponSkins: [upgradeSchema],
CrewShipSalvagedWeapons: [upgradeSchema],
Sainan commented 2025-03-23 08:44:08 -07:00
Owner
Copy Link

upgradeSchema is not correct for CrewShipSalvagedWeapons

upgradeSchema is not correct for CrewShipSalvagedWeapons
Sainan marked this conversation as resolved
AMelonInsideLemon added 1 commit 2025-03-23 09:51:56 -07:00
schema for CrewShipSalvagedWeapons
All checks were successful
Build / build (18) (pull_request) Successful in 43s
Details
Build / build (22) (pull_request) Successful in 1m11s
Details
Build / build (20) (pull_request) Successful in 1m27s
Details
3fcd5719e0
Sainan commented 2025-03-23 11:17:22 -07:00
Owner
Copy Link

Couldn't the equipment logic just be reused for crewship weapons?

Couldn't the equipment logic just be reused for crewship weapons?
AMelonInsideLemon commented 2025-03-23 11:22:32 -07:00
Author
Contributor
Copy Link

Config filed is optional in crewship weapons, idk what the game will do if we put empty config in every rj weapon

Config filed is optional in crewship weapons, idk what the game will do if we put empty config in every rj weapon
Sainan commented 2025-03-23 11:24:32 -07:00
Owner
Copy Link

Well, I think everything is kinda optional on live, but it's not really an issue that we default some fields afaik.

Well, I think everything is kinda optional on live, but it's not really an issue that we default some fields afaik.
AMelonInsideLemon added 1 commit 2025-03-23 11:42:55 -07:00
CrewShipWeapon is now Equipment
All checks were successful
Build / build (22) (pull_request) Successful in 40s
Details
Build / build (20) (pull_request) Successful in 1m12s
Details
Build / build (18) (pull_request) Successful in 1m36s
Details
0b372bc6d3
Sainan commented 2025-03-23 12:02:38 -07:00
Owner
Copy Link

You will have to rebase your PR branch as it currently has a merge conflict with main.

You will have to rebase your PR branch as it currently has a merge conflict with main.
AMelonInsideLemon force-pushed importer-new-fields from 0b372bc6d3 to 45db693c8c 2025-03-23 12:05:25 -07:00 Compare
AMelonInsideLemon commented 2025-03-23 12:05:44 -07:00
Author
Contributor
Copy Link

Thanks

Thanks
Sainan approved these changes 2025-03-23 12:11:03 -07:00
Sainan merged commit 0085c20e11 into main 2025-03-23 13:33:27 -07:00
Sainan deleted branch importer-new-fields 2025-03-23 13:33:27 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1305
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:importer-new-fields"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?