OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

fix: don't touch NemesisAbandonedRewards when spawning a lich #1275

Merged
Sainan merged 1 commits from no-abanonded into main 2025-03-22 07:30:30 -07:00
Conversation 0 Commits 1 Files Changed 1 +1 -2
Sainan commented 2025-03-22 06:20:38 -07:00
Owner
Copy Link

Because this can contain both grineer and corpus weapons, I think we should simply defer to the client's missionInventoryUpdate request in this matter.
This still leaves open the possibility of the client crashing between spawning the lich and finishing the mission, but that's rather unlikely, I guess.

Because this can contain both grineer and corpus weapons, I think we should simply defer to the client's missionInventoryUpdate request in this matter. This still leaves open the possibility of the client crashing between spawning the lich and finishing the mission, but that's rather unlikely, I guess.
Sainan added 1 commit 2025-03-22 06:20:39 -07:00
fix: don't touch NemesisAbandonedRewards when spawning a lich
All checks were successful
Build / build (20) (push) Successful in 1m9s
Details
Build / build (18) (pull_request) Successful in 42s
Details
Build / build (22) (pull_request) Successful in 38s
Details
Build / build (18) (push) Successful in 43s
Details
Build / build (22) (push) Successful in 1m25s
Details
Build / build (20) (pull_request) Successful in 1m9s
Details
0b954e97a2 
Because this can contain both grineer and corpus weapons, I think we should simply defer to the client's missionInventoryUpdate request in this matter.
This still leaves open the possibility of the client crashing between spawning the lich and finishing the mission, but that's rather unlikely, I guess.
Sainan merged commit 57786bfffb into main 2025-03-22 07:30:30 -07:00
Sainan deleted branch no-abanonded 2025-03-22 07:30:30 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1275
No description provided.
Delete Branch "no-abanonded"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?