OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat: mastery rank up inbox message #1206

Merged
OrdisPrime merged 1 commits from mastery-slates into main 2025-03-17 12:23:17 -07:00
Conversation 2 Commits 1 Files Changed 2 +22 -2
Sainan commented 2025-03-15 13:23:00 -07:00
Owner
Copy Link

Closes #1203

Closes #1203
Sainan added 1 commit 2025-03-15 13:23:00 -07:00
feat: mastery rank up inbox message
All checks were successful
Build / build (20) (push) Successful in 37s
Details
Build / build (18) (push) Successful in 1m4s
Details
Build / build (22) (push) Successful in 1m1s
Details
Build / build (18) (pull_request) Successful in 40s
Details
Build / build (20) (pull_request) Successful in 1m2s
Details
Build / build (22) (pull_request) Successful in 1m7s
Details
366e57b8d5
Sainan requested review from OrdisPrime 2025-03-16 08:15:50 -07:00
OrdisPrime reviewed 2025-03-17 12:08:53 -07:00
src/models/inboxModel.ts
@ -100,3 +100,3 @@
{
Key: String,
Tag: String,
Tag: Schema.Types.Mixed,
OrdisPrime commented 2025-03-17 12:08:53 -07:00
Owner
Copy Link

why use mixed here? its the same as allowing everything. We should certainly not use mixed for anything that was validated.
Mixed was only set for things that are not implemented

why use mixed here? its the same as allowing everything. We should certainly not use mixed for anything that was validated. Mixed was only set for things that are not implemented
Sainan commented 2025-03-17 12:12:14 -07:00
Author
Owner
Copy Link

Because it can also be a number.

Because it can also be a number.
OrdisPrime marked this conversation as resolved
OrdisPrime reviewed 2025-03-17 12:09:36 -07:00
src/models/inboxModel.ts
@ -41,3 +41,3 @@
export interface Arg {
Key: string;
Tag: string;
Tag: string | number;
OrdisPrime commented 2025-03-17 12:09:36 -07:00
Owner
Copy Link

tag can be a number? I don't see why this pr needs that change, so I don't know where it's coming from

tag can be a number? I don't see why this pr needs that change, so I don't know where it's coming from
Sainan commented 2025-03-17 12:12:06 -07:00
Author
Owner
Copy Link

The NEW_RANK is a number.

The `NEW_RANK` is a number.
OrdisPrime commented 2025-03-17 12:16:59 -07:00
Owner
Copy Link

I think this might be a DE moment, and the client can just work with both.
It just work when a number is supplied, right?
I sadly can't try now.

I think this might be a DE moment, and the client can just work with both. It just work when a number is supplied, right? I sadly can't try now.
Sainan commented 2025-03-17 12:20:02 -07:00
Author
Owner
Copy Link

Yeah, it's a number in my inbox messages.

Yeah, it's a number in my inbox messages.
OrdisPrime commented 2025-03-17 12:22:55 -07:00
Owner
Copy Link

Yeah, it's a number in my inbox messages.

Weird situation, well in that case we gotta use mixed, you are right.
PR is good to go

> Yeah, it's a number in my inbox messages. Weird situation, well in that case we gotta use mixed, you are right. PR is good to go
OrdisPrime merged commit b4da457501 into main 2025-03-17 12:23:17 -07:00
OrdisPrime deleted branch mastery-slates 2025-03-17 12:23:17 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
OrdisPrime
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1206
No description provided.
Delete Branch "mastery-slates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?