OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

chore: changed noDailyStandingLimits to 999.999.999 to avoid potential confusion when having MR 65K+ #1200

Closed
Animan8000 wants to merge 1 commits from (deleted):animan8000-patch-1 into main
pull from: (deleted):animan8000-patch-1
merge into: OpenWF:main
Conversation 1 Commits 1 Files Changed 1 +1 -1
Animan8000 commented 2025-03-15 10:10:18 -07:00
Contributor
Copy Link

When you have a very high mastery rank, the user technically has an even higher cap (higher than 999.999) and it doesn't cover the entire standing cap in-game visually, which may look a little confusing to the end user. It would also be consistent with the infinite plat & credits amount. I know, I know, technically really pointless but that's what I mean and why I preferred to change:

Before:

image.png
image.png

After:

image.png
{F68C9DF4-0172-4E74-B4EB-E39B9583E58F}.png

When you have a very high mastery rank, the user technically has an even higher cap (higher than 999.999) and it doesn't cover the entire standing cap in-game visually, which may look a little confusing to the end user. It would also be consistent with the infinite plat & credits amount. I know, I know, technically really pointless but that's what I mean and why I preferred to change: Before: ![image.png](/attachments/d419f2b3-2b6c-419b-9c4f-58b1486ba100) ![image.png](/attachments/39e2765c-57e1-42dd-8ec9-85d3a2c08313) After: ![image.png](/attachments/8a6d78f8-59ac-4456-ac16-900854876bd1) <img width="699" alt="{F68C9DF4-0172-4E74-B4EB-E39B9583E58F}.png" src="attachments/49cb3877-5e3b-49cc-bb14-8a51c4d4d1b2">
image.png
137 KiB
image.png
1.4 MiB
{F68C9DF4-0172-4E74-B4EB-E39B9583E58F}.png
155 KiB
image.png
192 KiB
Animan8000 added 1 commit 2025-03-15 10:10:19 -07:00
chore: changed noDailyStandingLimits to 999.999.999 to avoid potential confusion when having MR 65K+
All checks were successful
Build / build (20) (pull_request) Successful in 40s
Details
Build / build (18) (pull_request) Successful in 1m10s
Details
Build / build (22) (pull_request) Successful in 1m12s
Details
b6181858a0 
When you have a very high mastery rank, the user technically has an even higher cap (higher than 999.999) and it doesn't cover the entire standing cap in-game visually, which may look a little confusing to the end user. It would also be consistent with the infinite plat & credits amount. I know, I know, technically really pointless but that's what I mean and why I preferred to change:

Before:

https://cdn.discordapp.com/attachments/1350514154959667224/1350514204574093474/BF0C5B98-23BB-42F9-975A-986C664C1FF8.png?ex=67d703dd&is=67d5b25d&hm=63ed4adc582cc1171a9500e8053b8c33262006937bb98389f8316e083cac1298&
https://cdn.discordapp.com/attachments/1350514154959667224/1350514220503924786/3A9E9851-3DBE-4A2B-BEF4-DDA5EE3EA6C4.png?ex=67d703e1&is=67d5b261&hm=4ef8f4ffae4663921094c732c863084cbe342c677b26191a4af01d4cb7e25f23&

After:

https://cdn.discordapp.com/attachments/1350514154959667224/1350514254926581891/7756A1B4-AE30-49CF-9E16-AE3C37D25CB1.png?ex=67d703e9&is=67d5b269&hm=7c29987cc87db3d7657eaab53073cecd66818d48a2c7e980594c4a3029f6e907&
https://cdn.discordapp.com/attachments/1350514154959667224/1350514292121796608/B2015634-87B0-4E28-B66D-4B6A206C0BE6.png?ex=67d703f2&is=67d5b272&hm=fda40dee88c29872e40c5cdb8e5aa3453374288dd2de3274d3df75efafa24455&
Sainan commented 2025-03-15 10:21:54 -07:00
Owner
Copy Link

I don't like that the text breaks out, so I made my own PR: #1201

I don't like that the text breaks out, so I made my own PR: #1201
👍 1
Sainan closed this pull request 2025-03-15 10:21:54 -07:00
All checks were successful
Build / build (20) (pull_request) Successful in 40s
Details
Build / build (18) (pull_request) Successful in 1m10s
Details
Build / build (22) (pull_request) Successful in 1m12s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1200
No description provided.
Delete Branch "(deleted):animan8000-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?