OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

chore: fix various eslint issues #1176

Merged
Sainan merged 1 commits from eslint-fix into main 2025-03-15 03:24:39 -07:00
Conversation 1 Commits 1 Files Changed 16 +111 -75
Sainan commented 2025-03-14 05:22:44 -07:00
Owner
Copy Link
No description provided.
Sainan added 1 commit 2025-03-14 05:22:45 -07:00
chore: fix various eslint issues
All checks were successful
Build / build (18) (pull_request) Successful in 43s
Details
Build / build (22) (pull_request) Successful in 1m4s
Details
Build / build (18) (push) Successful in 44s
Details
Build / build (20) (push) Successful in 1m3s
Details
Build / build (22) (push) Successful in 1m2s
Details
Build / build (20) (pull_request) Successful in 40s
Details
1c4d5c5543
OrdisPrime reviewed 2025-03-14 06:08:07 -07:00
src/services/shipService.ts
@ -31,4 +30,2 @@
return ship;
};
export const getShipLean = async (shipOwnerId: string) => {
OrdisPrime commented 2025-03-14 06:08:07 -07:00
Owner
Copy Link

only because this function is currently not used, does not mean it has to be deleted.

only because this function is currently not used, does not mean it has to be deleted.
Sainan commented 2025-03-14 06:11:22 -07:00
Author
Owner
Copy Link

I don't even understand the intended purpose of it. Under which circumstances would you ever want an unhydrated ship combined with the loadout presets?

I don't even understand the intended purpose of it. Under which circumstances would you ever want an unhydrated ship combined with the loadout presets?
OrdisPrime commented 2025-03-14 06:13:18 -07:00
Owner
Copy Link

hydration is ONLY needed when you want to use a mongoose document's functions.
So, all get requests should generally only use .lean() versions, so mongoose doesn't hydrate them (which takes lots of resources)

hydration is ONLY needed when you want to use a mongoose document's functions. So, all get requests should generally only use .lean() versions, so mongoose doesn't hydrate them (which takes lots of resources)
OrdisPrime commented 2025-03-14 06:14:08 -07:00
Owner
Copy Link

I left the function there as a reminder to do that

I left the function there as a reminder to do that
Sainan commented 2025-03-14 06:15:39 -07:00
Author
Owner
Copy Link

lean also seems to skip casing and validation, potentially invalidating the types.

`lean` also seems to skip casing and validation, potentially invalidating the types.
OrdisPrime commented 2025-03-14 06:17:26 -07:00
Owner
Copy Link

I am not aware of that.
https://github.com/Automattic/mongoose/blob/master/docs/tutorials/lean.md
it describes getters as a good use case for using lean, which makes sense to me

I am not aware of that. https://github.com/Automattic/mongoose/blob/master/docs/tutorials/lean.md it describes getters as a good use case for using lean, which makes sense to me
Sainan commented 2025-03-14 06:17:53 -07:00
Author
Owner
Copy Link

Literally search for "Casting and validation" on that page.

Literally search for "Casting and validation" on that page.
Sainan commented 2025-03-14 06:20:49 -07:00
Author
Owner
Copy Link

The ship model also makes use of transformations, so we'd not get a correct client representation if we used lean.

The ship model also makes use of transformations, so we'd not get a correct client representation if we used `lean`.
OrdisPrime commented 2025-03-14 06:24:04 -07:00
Owner
Copy Link

Right, however I don't think validation or casting is required during retrieval of a document, since that also happens during saving, so it should be impossible to even have invalid objects. Other than when someone would manually change stuff, but accounting for that possibility does not seem reasonable.

Since we use virtuals, and they rely on hydration apparently, we cannot use .lean() indeed.

However, your change was sus to me, because you just removed it while it had a purpose. What we discovered now does not change that removing stuff just like that is not so great

Right, however I don't think validation or casting is required during retrieval of a document, since that also happens during saving, so it should be impossible to even have invalid objects. Other than when someone would manually change stuff, but accounting for that possibility does not seem reasonable. Since we use virtuals, and they rely on hydration apparently, we cannot use .lean() indeed. However, your change was sus to me, because you just removed it while it had a purpose. What we discovered now does not change that removing stuff just like that is not so great
Sainan commented 2025-03-14 06:26:00 -07:00
Author
Owner
Copy Link

I removed it because it didn't serve any apparent purpose and did not have a return type, hence raising a warning.

I removed it because it didn't serve any apparent purpose and did not have a return type, hence raising a warning.
OrdisPrime marked this conversation as resolved
Sainan merged commit 2891e2fef5 into main 2025-03-15 03:24:39 -07:00
Sainan deleted branch eslint-fix 2025-03-15 03:24:40 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1176
No description provided.
Delete Branch "eslint-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?