OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 44 Pull Requests 5 Actions Packages Projects Releases Activity

feat: handle EmailItems received during mission #1088

Merged
Sainan merged 3 commits from mission-EmailItems into main 2025-03-07 00:41:19 -08:00
Conversation 2 Commits 3 Files Changed 5 +50 -14
Sainan commented 2025-03-05 22:32:40 -08:00
Owner
Copy Link

Closes #1087

Closes #1087
Sainan added 1 commit 2025-03-05 22:32:40 -08:00
feat: handle EmailItems received during mission
All checks were successful
Build / build (22) (push) Successful in 36s
Details
Build / build (18) (push) Successful in 1m3s
Details
Build / build (20) (push) Successful in 53s
Details
Build / build (18) (pull_request) Successful in 40s
Details
Build / build (20) (pull_request) Successful in 1m1s
Details
Build / build (22) (pull_request) Successful in 53s
Details
1341b71177
VampireKitten commented 2025-03-06 07:45:19 -08:00
Contributor
Copy Link

Currently, this PR does not prevent getting the same email multiple times:

image.png
image.png

Currently, this PR does not prevent getting the same email multiple times: ![image.png](/attachments/cb28d502-5272-4df4-8af9-a245e1ffb8d4) ![image.png](/attachments/e224160f-6159-47da-b465-852f420c37ec)
image.png
440 KiB
image.png
446 KiB
Sainan commented 2025-03-06 07:58:45 -08:00
Author
Owner
Copy Link

Added proper tracking in inventory's EmailItems array so we know which ones have already been sent

Added proper tracking in inventory's `EmailItems` array so we know which ones have already been sent
Sainan force-pushed mission-EmailItems from 5a7d582f7f to dd74c27e98 2025-03-06 08:01:34 -08:00 Compare
Sainan force-pushed mission-EmailItems from dd74c27e98 to aff47e5ade 2025-03-06 08:02:43 -08:00 Compare
Sainan force-pushed mission-EmailItems from aff47e5ade to 26ad8fceff 2025-03-06 08:04:44 -08:00 Compare
Sainan added 1 commit 2025-03-06 08:06:19 -08:00
update ItemCount if EmailItem allows multiples
All checks were successful
Build / build (18) (push) Successful in 56s
Details
Build / build (20) (push) Successful in 57s
Details
Build / build (22) (push) Successful in 39s
Details
Build / build (22) (pull_request) Successful in 37s
Details
Build / build (20) (pull_request) Successful in 56s
Details
Build / build (18) (pull_request) Successful in 1m0s
Details
514e306394
Sainan merged commit 59fd816b0c into main 2025-03-07 00:41:19 -08:00
Sainan deleted branch mission-EmailItems 2025-03-07 00:41:19 -08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1088
No description provided.
Delete Branch "mission-EmailItems"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?