OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 41 Pull Requests 2 Actions Packages Projects Releases Activity

fix: don't throw an error if questKey already exists #1003

Merged
OrdisPrime merged 2 commits from AMelonInsideLemon/SpaceNinjaServer:questkey-warn into main 2025-02-24 15:59:57 -08:00
Conversation 0 Commits 2 Files Changed 2 +3 -4
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/services/inventoryService.ts
View File

@ -331,9 +331,8 @@ export const addItem = async (
if (key.chainStages) { if (key.chainStages) {
const key = addQuestKey(inventory, { ItemType: typeName }); const key = addQuestKey(inventory, { ItemType: typeName });
if (key) { if (!key) return { InventoryChanges: {} };
return { InventoryChanges: { QuestKeys: [key] } }; return { InventoryChanges: { QuestKeys: [key] } };
}
} else { } else {
const key = { ItemType: typeName, ItemCount: quantity }; const key = { ItemType: typeName, ItemCount: quantity };

2
src/services/questService.ts
View File

@ -77,7 +77,7 @@ export const updateQuestStage = (
export const addQuestKey = (inventory: TInventoryDatabaseDocument, questKey: IQuestKeyDatabase) => { export const addQuestKey = (inventory: TInventoryDatabaseDocument, questKey: IQuestKeyDatabase) => {
if (inventory.QuestKeys.some(q => q.ItemType === questKey.ItemType)) { if (inventory.QuestKeys.some(q => q.ItemType === questKey.ItemType)) {
logger.error(`quest key ${questKey.ItemType} already exists`); logger.warn(`Quest key ${questKey.ItemType} already exists. It will not be added`);
return; return;
} }
const index = inventory.QuestKeys.push(questKey); const index = inventory.QuestKeys.push(questKey);