From 9a646e0022b0b932c53d8aabdbaa1158169740f6 Mon Sep 17 00:00:00 2001
From: AMelonInsideLemon <166175391+AMelonInsideLemon@users.noreply.github.com>
Date: Mon, 24 Feb 2025 18:39:37 +0100
Subject: [PATCH 1/2] fix: don't throw an error if questKey already exists

---
 src/services/inventoryService.ts | 2 +-
 src/services/questService.ts     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/services/inventoryService.ts b/src/services/inventoryService.ts
index 92fc007d..bc188c0f 100644
--- a/src/services/inventoryService.ts
+++ b/src/services/inventoryService.ts
@@ -333,7 +333,7 @@ export const addItem = async (
             const key = addQuestKey(inventory, { ItemType: typeName });
             if (key) {
                 return { InventoryChanges: { QuestKeys: [key] } };
-            }
+            } else return { InventoryChanges: {} };
         } else {
             const key = { ItemType: typeName, ItemCount: quantity };
 
diff --git a/src/services/questService.ts b/src/services/questService.ts
index f7b502d5..65d7e509 100644
--- a/src/services/questService.ts
+++ b/src/services/questService.ts
@@ -77,7 +77,7 @@ export const updateQuestStage = (
 
 export const addQuestKey = (inventory: TInventoryDatabaseDocument, questKey: IQuestKeyDatabase) => {
     if (inventory.QuestKeys.some(q => q.ItemType === questKey.ItemType)) {
-        logger.error(`quest key ${questKey.ItemType} already exists`);
+        logger.warn(`Quest key ${questKey.ItemType} already exists. It will not be added`);
         return;
     }
     const index = inventory.QuestKeys.push(questKey);
-- 
2.47.2


From 1f6da504d674ee1f016028440db41a32a4bfdce8 Mon Sep 17 00:00:00 2001
From: AMelonInsideLemon <166175391+AMelonInsideLemon@users.noreply.github.com>
Date: Tue, 25 Feb 2025 00:58:50 +0100
Subject: [PATCH 2/2] Update inventoryService.ts

---
 src/services/inventoryService.ts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/services/inventoryService.ts b/src/services/inventoryService.ts
index bc188c0f..597a4bb7 100644
--- a/src/services/inventoryService.ts
+++ b/src/services/inventoryService.ts
@@ -331,9 +331,8 @@ export const addItem = async (
 
         if (key.chainStages) {
             const key = addQuestKey(inventory, { ItemType: typeName });
-            if (key) {
-                return { InventoryChanges: { QuestKeys: [key] } };
-            } else return { InventoryChanges: {} };
+            if (!key) return { InventoryChanges: {} };
+            return { InventoryChanges: { QuestKeys: [key] } };
         } else {
             const key = { ItemType: typeName, ItemCount: quantity };
 
-- 
2.47.2