improve: Add Ergo Blast's Tenet Weapon shop #568
Loading…
x
Reference in New Issue
Block a user
No description provided.
Delete Branch "add-ergo-blast"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #567. If anyone can find any missing shops, please tell me.
Walkthrough
The pull request introduces an enhancement to the
getVendorInfoController
function by adding a new case for handling the vendor manifest located at"/Lotus/Types/Game/VendorManifests/Hubs/PerrinSequenceWeaponVendorManifest"
. This update allows the controller to return theHubsPerrinSequenceWeaponVendorManifest
JSON data, thereby expanding the types of vendor information that can be retrieved based on query parameters. The structure of the existing switch statement in the controller remains unchanged, ensuring that the integration of the new case is seamless. Additionally, a new JSON file has been created to define the vendor manifest for the "Hubs Perrin Sequence Weapon Vendor," which includes detailed information about the vendor and the items available for purchase, such as pricing, attributes, and identifiers.Assessment against linked issues
Possibly related PRs
getVendorInfoController
function, specifically adding new vendor cases and JSON imports, which relates directly to the modifications made in the main PR regarding vendor manifests.Suggested reviewers
📜 Recent review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📥 Commits
Files that changed from the base of the PR and between
598fc6e0ee
ande165832aef
.📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
❤️ Share
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
I pushed a fix in commit <commit_id>, please review it.
Generate unit testing code for this file.
Open a follow-up GitHub issue for this discussion.
@coderabbitai
in a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.
@coderabbitai modularize this function.
@coderabbitai
in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
@coderabbitai read src/utils.ts and generate unit testing code.
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pause
to pause the reviews on a PR.@coderabbitai resume
to resume the paused reviews.@coderabbitai review
to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full review
to do a full review from scratch and review all the files again.@coderabbitai summary
to regenerate the summary of the PR.@coderabbitai resolve
resolve all the CodeRabbit review comments.@coderabbitai configuration
to show the current CodeRabbit configuration for the repository.@coderabbitai help
to get help.Other keywords and placeholders
@coderabbitai ignore
anywhere in the PR description to prevent this PR from being reviewed.@coderabbitai summary
to generate the high-level summary at a specific location in the PR description.@coderabbitai
anywhere in the PR title to generate the title automatically.Documentation and Community
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📥 Commits
Files that changed from the base of the PR and between
1a029ebb4b
and598fc6e0ee
.📒 Files selected for processing (2)
🧰 Additional context used
🔇 Additional comments (6)
Wow, it's almost like I had already done that...
Looks like the
Expiry
is quite soonIiiiiii forgot to change the expiry, didn't I. I changed it for Palladino, completely forgot here.