OpenWF/SpaceNinjaServer
28
29
Fork 34
Code Issues 26 Pull Requests 6 Actions Packages Projects Releases Activity

feat: deepmines bounties #2933

Merged
Sainan merged 4 commits from AMelonInsideLemon/SpaceNinjaServer:deepmines-bounties-rewards into main 2025-10-26 06:37:44 -07:00
Conversation 8 Commits 4 Files Changed 3 +34 -10
AMelonInsideLemon commented 2025-10-23 17:45:01 -07:00
Member
Copy Link

Closes #2936

Closes #2936
AMelonInsideLemon added 1 commit 2025-10-23 17:45:02 -07:00
feat: deepmines bounties
All checks were successful
Build / build (pull_request) Successful in 1m8s
Details
8104e2fc27
Sainan approved these changes 2025-10-23 23:16:02 -07:00
Dismissed
Sainan commented 2025-10-24 05:57:54 -07:00
Owner
Copy Link

Actually, how is this supposed to give rewards given that it's not in ExportRewards ?

Actually, how is this supposed to give rewards given that it's not in ExportRewards ?
AMelonInsideLemon commented 2025-10-24 06:00:56 -07:00
Author
Member
Copy Link

oops, I forgot about that

oops, I forgot about that
AMelonInsideLemon changed title from feat: deepmines bounties to WIP: feat: deepmines bounties 2025-10-24 06:01:01 -07:00
Sainan dismissed Sainan’s review 2025-10-24 06:02:39 -07:00
Sainan commented 2025-10-25 00:23:00 -07:00
Owner
Copy Link

Now available with PE+ 0.5.93

Now available with PE+ 0.5.93
AMelonInsideLemon added 1 commit 2025-10-25 00:27:23 -07:00
update pe+
All checks were successful
Build / build (pull_request) Successful in 1m9s
Details
42c26b0fc9
AMelonInsideLemon changed title from WIP: feat: deepmines bounties to feat: deepmines bounties 2025-10-25 00:27:27 -07:00
Sainan commented 2025-10-25 00:28:07 -07:00
Owner
Copy Link

Just to be clear, you did test this PR, yes?

Just to be clear, you did test this PR, yes?
AMelonInsideLemon added 1 commit 2025-10-25 00:35:34 -07:00
Update missionInventoryUpdateService.ts
All checks were successful
Build / build (pull_request) Successful in 2m56s
Details
a5403ef1c0
AMelonInsideLemon commented 2025-10-25 00:37:39 -07:00
Author
Member
Copy Link

Yep, yesterday, it should be working now, only droptables was missing.

Yep, yesterday, it should be working now, only droptables was missing.
Sainan reviewed 2025-10-25 00:48:42 -07:00
src/services/missionInventoryUpdateService.ts Outdated
@ -2176,3 +2186,1 @@
const drop = getRandomRewardByChance(rotationRewards, rng);
if (drop) {
drops.push({ StoreItem: drop.type, ItemCount: drop.itemCount });
if (rotations.length > 1) {
Sainan commented 2025-10-25 00:48:42 -07:00
Owner
Copy Link

Why this change? What if rotations.length == 1?

Why this change? What if `rotations.length == 1`?
AMelonInsideLemon added 1 commit 2025-10-25 01:04:50 -07:00
avoid unnecessary cucling rewardManifests.forEach
All checks were successful
Build / build (pull_request) Successful in 1m10s
Details
046c7d9cab
Sainan approved these changes 2025-10-25 07:15:09 -07:00
Sainan merged commit 3ae535ccbc into main 2025-10-26 06:37:44 -07:00
Sainan deleted branch deepmines-bounties-rewards 2025-10-26 06:37:45 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Sainan
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#2933
No description provided.
Delete Branch "AMelonInsideLemon/SpaceNinjaServer:deepmines-bounties-rewards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?