OpenWF/SpaceNinjaServer
12
6
Fork 14
Code Issues 43 Pull Requests 4 Actions Packages Projects Releases Activity

fix: handle tileset-specific sortie modifiers #1958

Merged
Sainan merged 1 commits from hazards into main 2025-05-02 15:07:00 -07:00
Conversation 2 Commits 1 Files Changed 1 +26 -7
Sainan commented 2025-05-01 14:47:08 -07:00
Owner
Copy Link

Closes #1956

Closes #1956
Sainan added 1 commit 2025-05-01 14:47:08 -07:00
fix: handle tileset-specific sortie modifiers
All checks were successful
Build / build (push) Successful in 1m34s
Details
Build / build (pull_request) Successful in 1m2s
Details
0f28a0a1ea
AMelonInsideLemon reviewed 2025-05-02 09:25:55 -07:00
src/services/worldStateService.ts
@ -311,1 +306,4 @@
];
const pushTilesetModifiers = (tileset: string): void => {
switch (tileset) {
case "SORTIE_MODIFIER_HAZARD_FOG":
AMelonInsideLemon commented 2025-05-02 09:25:55 -07:00
Contributor
Copy Link

I think there should be GrineerForestTileset not SORTIE_MODIFIER_HAZARD_FOG

I think there should be `GrineerForestTileset` not `SORTIE_MODIFIER_HAZARD_FOG`
Animan8000 commented 2025-05-02 09:47:44 -07:00
Contributor
Copy Link

Does this exclude Fire Hazard condition from Grineer Shipyard tile? Because in yesterday's Sortie it was on that tile, even though the wiki states: Can only occur on the Corpus Ship or Grineer Galleon tileset.

https://wiki.warframe.com/w/Sortie

Aside of that, the wiki also mentions Radiation Hazard: This modifier cannot occur with Interception missions.

And about Melee only: This modifier cannot occur with Assassination missions.

And the Dense Fog exclusive to Grineer Forest tile is apparently only during night. Idk if this must be handled by the server.

And then the typical mission types intended to it (idk if all get currently generated): Rescue, Spy, Defense, Interception, Excavation, Survival, Exterminate, Defection, Hijack, Assassination, Plains of Eidolon, Disruption, and Assault (strangely not listed in the wiki but it shows apparently still up on Live these days as mission type on Kuva Fortress).

Does this exclude Fire Hazard condition from Grineer Shipyard tile? Because in yesterday's Sortie it was on that tile, even though the wiki states: `Can only occur on the Corpus Ship or Grineer Galleon tileset.` https://wiki.warframe.com/w/Sortie Aside of that, the wiki also mentions Radiation Hazard: `This modifier cannot occur with Interception missions.` And about Melee only: `This modifier cannot occur with Assassination missions.` And the Dense Fog exclusive to Grineer Forest tile is apparently only during night. Idk if this must be handled by the server. And then the typical mission types intended to it (idk if all get currently generated): Rescue, Spy, Defense, Interception, Excavation, Survival, Exterminate, Defection, Hijack, Assassination, Plains of Eidolon, Disruption, and Assault (strangely not listed in the wiki but it shows apparently still up on Live these days as mission type on Kuva Fortress).
Sainan merged commit 468efed71c into main 2025-05-02 15:07:00 -07:00
Sainan deleted branch hazards 2025-05-02 15:07:02 -07:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
An existing implemention is incorrect
dependencies
Pull requests that update a dependency file
documentation
Improvements or additions to documentation
enhancement
New feature or request specific to the emulator
help wanted
Extra attention is needed
improvement
missing data
part of more major rehaul
Can't be worked on right now without merge conflicts later
pr'd for
Soon™
question
Further information is requested
unimplemented
you can do this
Considered easy enough for someone's first PR.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: OpenWF/SpaceNinjaServer#1958
No description provided.
Delete Branch "hazards"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?