OpenWF/SpaceNinjaServer
21
23
Fork 29
Code Issues 23 Pull Requests 3 Actions Packages Projects Releases Activity

fix: ignore rewardQualifications for non-endless mission types (#2590)
All checks were successful
Build / build (push) Successful in 1m7s
Details
Build Docker image / docker-arm64 (push) Successful in 1m9s
Details
Build Docker image / docker-amd64 (push) Successful in 53s
Details

Browse Source 
Closes #2586

Reviewed-on: #2590
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
This commit is contained in:
Sainan 2025-08-06 04:01:01 -07:00 committed by Sainan
parent 834b7a8196
commit a2d383ee3c
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/services/missionInventoryUpdateService.ts
View File

@ -100,6 +100,11 @@ const getRotations = (rewardInfo: IRewardInfo, tierOverride?: number): number[]
return [rewardInfo.rewardTier];
}
// 'rewardQualifications' is unreliable for mission types that only have rotation A (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/2586)
if (missionIndex == 0 || missionIndex == 1 || missionIndex == 5) {
return [0];
}
const rotationCount = rewardInfo.rewardQualifications?.length || 0;
// Empty or absent rewardQualifications should not give rewards when: