From a2d383ee3c6689b6ee90a944a862cab9eae50a1f Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Wed, 6 Aug 2025 04:01:01 -0700 Subject: [PATCH] fix: ignore rewardQualifications for non-endless mission types (#2590) Closes #2586 Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/2590 Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com> Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com> --- src/services/missionInventoryUpdateService.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index 4a8da370..1125be42 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -100,6 +100,11 @@ const getRotations = (rewardInfo: IRewardInfo, tierOverride?: number): number[] return [rewardInfo.rewardTier]; } + // 'rewardQualifications' is unreliable for mission types that only have rotation A (https://onlyg.it/OpenWF/SpaceNinjaServer/issues/2586) + if (missionIndex == 0 || missionIndex == 1 || missionIndex == 5) { + return [0]; + } + const rotationCount = rewardInfo.rewardQualifications?.length || 0; // Empty or absent rewardQualifications should not give rewards when: