OpenWF/SpaceNinjaServer
12
6
Fork 15
Code Issues 45 Pull Requests 6 Actions Packages Projects Releases Activity

optimise getItemLists request by only fetching dict once

Browse Source
This commit is contained in:
Sainan 2024-12-22 01:50:27 +01:00
parent c98c56c0ab
commit 71dfa789df
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/controllers/custom/getItemListsController.ts
View File

@ -1,5 +1,5 @@
import { RequestHandler } from "express"; import { RequestHandler } from "express";
import { getString } from "@/src/services/itemDataService"; import { getDict, getString } from "@/src/services/itemDataService";
import { import {
ExportArcanes, ExportArcanes,
ExportGear, ExportGear,
@ -17,7 +17,7 @@ interface ListedItem {
} }
const getItemListsController: RequestHandler = (req, res) => { const getItemListsController: RequestHandler = (req, res) => {
const lang = typeof req.query.lang == "string" ? req.query.lang : "en"; const lang = getDict(typeof req.query.lang == "string" ? req.query.lang : "en");
const weapons = []; const weapons = [];
const miscitems = []; const miscitems = [];
for (const [uniqueName, item] of Object.entries(ExportWeapons)) { for (const [uniqueName, item] of Object.entries(ExportWeapons)) {

3
src/services/itemDataService.ts
View File

@ -118,7 +118,6 @@ export const getDict = (lang: string): Record<string, string> => {
return dict_en; return dict_en;
}; };
export const getString = (key: string, lang: string = "en"): string => { export const getString = (key: string, dict: Record<string, string>): string => {
const dict = getDict(lang);
return dict[key] ?? key; return dict[key] ?? key;
}; };