From 71dfa789df27c33cbbbe3a2c2ddfb0810327286b Mon Sep 17 00:00:00 2001
From: Sainan <sainan@calamity.inc>
Date: Sun, 22 Dec 2024 01:50:27 +0100
Subject: [PATCH] optimise getItemLists request by only fetching dict once

---
 src/controllers/custom/getItemListsController.ts | 4 ++--
 src/services/itemDataService.ts                  | 3 +--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/controllers/custom/getItemListsController.ts b/src/controllers/custom/getItemListsController.ts
index d1048603..914bd5cc 100644
--- a/src/controllers/custom/getItemListsController.ts
+++ b/src/controllers/custom/getItemListsController.ts
@@ -1,5 +1,5 @@
 import { RequestHandler } from "express";
-import { getString } from "@/src/services/itemDataService";
+import { getDict, getString } from "@/src/services/itemDataService";
 import {
     ExportArcanes,
     ExportGear,
@@ -17,7 +17,7 @@ interface ListedItem {
 }
 
 const getItemListsController: RequestHandler = (req, res) => {
-    const lang = typeof req.query.lang == "string" ? req.query.lang : "en";
+    const lang = getDict(typeof req.query.lang == "string" ? req.query.lang : "en");
     const weapons = [];
     const miscitems = [];
     for (const [uniqueName, item] of Object.entries(ExportWeapons)) {
diff --git a/src/services/itemDataService.ts b/src/services/itemDataService.ts
index c95707e9..ca9c0b0b 100644
--- a/src/services/itemDataService.ts
+++ b/src/services/itemDataService.ts
@@ -118,7 +118,6 @@ export const getDict = (lang: string): Record<string, string> => {
     return dict_en;
 };
 
-export const getString = (key: string, lang: string = "en"): string => {
-    const dict = getDict(lang);
+export const getString = (key: string, dict: Record<string, string>): string => {
     return dict[key] ?? key;
 };