OpenWF/SpaceNinjaServer
28
29
Fork 35
Code Issues 23 Pull Requests 1 Actions Packages Projects Releases Activity

fix: move getDialogue preconditions into the function itself (#2679)
All checks were successful
Build Docker image / docker-arm64 (push) Successful in 1m4s
Details
Build Docker image / docker-amd64 (push) Successful in 53s
Details
Build / build (push) Successful in 1m40s
Details

Browse Source 
Closes #2678

Reviewed-on: #2679
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
This commit is contained in:
Sainan 2025-08-22 11:46:04 -07:00 committed by Sainan
parent 9c232bfc1f
commit 5e1ff64cca
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/controllers/api/saveDialogueController.ts
View File

@ -20,8 +20,6 @@ export const saveDialogueController: RequestHandler = async (req, res) => {
const tomorrowAt0Utc = config.noKimCooldowns const tomorrowAt0Utc = config.noKimCooldowns
? Date.now() ? Date.now()
: (Math.trunc(Date.now() / 86400_000) + 1) * 86400_000; : (Math.trunc(Date.now() / 86400_000) + 1) * 86400_000;
inventory.DialogueHistory ??= {};
inventory.DialogueHistory.Dialogues ??= [];
const dialogue = getDialogue(inventory, request.DialogueName); const dialogue = getDialogue(inventory, request.DialogueName);
dialogue.Rank = request.Rank; dialogue.Rank = request.Rank;
dialogue.Chemistry += request.Chemistry; dialogue.Chemistry += request.Chemistry;

8
src/services/inventoryService.ts
View File

@ -2286,11 +2286,13 @@ export const cleanupInventory = (inventory: TInventoryDatabaseDocument): void =>
}; };
export const getDialogue = (inventory: TInventoryDatabaseDocument, dialogueName: string): IDialogueDatabase => { export const getDialogue = (inventory: TInventoryDatabaseDocument, dialogueName: string): IDialogueDatabase => {
let dialogue = inventory.DialogueHistory!.Dialogues!.find(x => x.DialogueName == dialogueName); inventory.DialogueHistory ??= {};
inventory.DialogueHistory.Dialogues ??= [];
let dialogue = inventory.DialogueHistory.Dialogues.find(x => x.DialogueName == dialogueName);
if (!dialogue) { if (!dialogue) {
dialogue = dialogue =
inventory.DialogueHistory!.Dialogues![ inventory.DialogueHistory.Dialogues[
inventory.DialogueHistory!.Dialogues!.push({ inventory.DialogueHistory.Dialogues.push({
Rank: 0, Rank: 0,
Chemistry: 0, Chemistry: 0,
AvailableDate: new Date(0), AvailableDate: new Date(0),