chore: ask mongoose if import did anything (#3047)

Partially reverting 71785fffd7 for a much simpler solution.

Reviewed-on: #3047
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>

src/controllers/custom/importController.ts

@@ -15,16 +15,19 @@ export const importController: RequestHandler = async (req, res) => {
     let anyKnownKey = false;
     try {
         const inventory = await getInventory(accountId);
-        if (importInventory(inventory, request.inventory)) {
+        importInventory(inventory, request.inventory);
+        if (inventory.isModified()) {
             anyKnownKey = true;
             await inventory.save();
         }
 
         if ("LoadOutPresets" in request.inventory && request.inventory.LoadOutPresets) {
-            anyKnownKey = true;
             const loadout = await getLoadout(accountId);
             importLoadOutPresets(loadout, request.inventory.LoadOutPresets);
-            await loadout.save();
+            if (loadout.isModified()) {
+                anyKnownKey = true;
+                await loadout.save();
+            }
         }
 
         if (
@@ -32,10 +35,12 @@ export const importController: RequestHandler = async (req, res) => {
             "Apartment" in request.inventory ||
             "TailorShop" in request.inventory
         ) {
-            anyKnownKey = true;
             const personalRooms = await getPersonalRooms(accountId);
             importPersonalRooms(personalRooms, request.inventory);
-            await personalRooms.save();
+            if (personalRooms.isModified()) {
+                anyKnownKey = true;
+                await personalRooms.save();
+            }
         }
 
         if (!anyKnownKey) {

src/services/importService.ts

@@ -254,21 +254,17 @@ const convertItemConfig = <T extends IItemConfig>(client: T): T => {
     };
 };
 
-export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): boolean => {
-    let anyKnownKey = false;
+export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<IInventoryClient>): void => {
     for (const key of equipmentKeys) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             replaceArray<IEquipmentDatabase>(db[key], client[key].map(convertEquipment));
         }
     }
     if (client.WeaponSkins !== undefined) {
-        anyKnownKey = true;
         replaceArray<IWeaponSkinDatabase>(db.WeaponSkins, client.WeaponSkins.map(convertWeaponSkin));
     }
     for (const key of ["Upgrades", "CrewShipSalvagedWeaponSkins", "CrewShipWeaponSkins"] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             replaceArray<IUpgradeDatabase>(db[key], client[key].map(convertUpgrade));
         }
     }
@@ -284,7 +280,6 @@ export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<
         "CrewShipRawSalvage"
     ] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             db[key].splice(0, db[key].length);
             client[key].forEach(x => {
                 db[key].push({
@@ -296,13 +291,11 @@ export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<
     }
     for (const key of ["AdultOperatorLoadOuts", "OperatorLoadOuts", "KahlLoadOuts"] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             replaceArray<IOperatorConfigDatabase>(db[key], client[key].map(convertOperatorConfig));
         }
     }
     for (const key of slotNames) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             replaceSlots(db[key], client[key]);
         }
     }
@@ -319,7 +312,6 @@ export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<
         "Counselor"
     ] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             db[key] = client[key];
         }
     }
@@ -346,7 +338,6 @@ export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<
         "EchoesHexConquestCacheScoreMission"
     ] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             db[key] = client[key];
         }
     }
@@ -362,7 +353,6 @@ export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<
         "ActiveAvatarImageType"
     ] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             db[key] = client[key];
         }
     }
@@ -379,7 +369,6 @@ export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<
         "EchoesHexConquestActiveStickers"
     ] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             db[key] = client[key];
         }
     }
@@ -393,133 +382,103 @@ export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<
         "EntratiVaultCountResetDate"
     ] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             db[key] = fromMongoDate(client[key]);
         }
     }
     // IRewardAtten[]
     for (const key of ["SortieRewardAttenuation", "SpecialItemRewardAttenuation"] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             db[key] = client[key];
         }
     }
     if (client.XPInfo !== undefined) {
-        anyKnownKey = true;
         db.XPInfo = client.XPInfo;
     }
     if (client.CurrentLoadOutIds !== undefined) {
-        anyKnownKey = true;
         db.CurrentLoadOutIds = client.CurrentLoadOutIds;
     }
     if (client.Affiliations !== undefined) {
-        anyKnownKey = true;
         db.Affiliations = client.Affiliations;
     }
     if (client.FusionTreasures !== undefined) {
-        anyKnownKey = true;
         db.FusionTreasures = client.FusionTreasures;
     }
     if (client.FocusUpgrades !== undefined) {
-        anyKnownKey = true;
         db.FocusUpgrades = client.FocusUpgrades;
     }
     if (client.EvolutionProgress !== undefined) {
-        anyKnownKey = true;
         db.EvolutionProgress = client.EvolutionProgress;
     }
     if (client.InfestedFoundry !== undefined) {
-        anyKnownKey = true;
         db.InfestedFoundry = convertInfestedFoundry(client.InfestedFoundry);
     }
     if (client.DialogueHistory !== undefined) {
-        anyKnownKey = true;
         db.DialogueHistory = convertDialogueHistory(client.DialogueHistory);
     }
     if (client.CustomMarkers !== undefined) {
-        anyKnownKey = true;
         db.CustomMarkers = client.CustomMarkers;
     }
     if (client.ChallengeProgress !== undefined) {
-        anyKnownKey = true;
         db.ChallengeProgress = client.ChallengeProgress;
     }
     if (client.QuestKeys !== undefined) {
-        anyKnownKey = true;
         replaceArray<IQuestKeyDatabase>(db.QuestKeys, client.QuestKeys.map(convertQuestKey));
     }
     if (client.LastRegionPlayed !== undefined) {
-        anyKnownKey = true;
         db.LastRegionPlayed = client.LastRegionPlayed;
     }
     if (client.PendingRecipes !== undefined) {
-        anyKnownKey = true;
         replaceArray<IPendingRecipeDatabase>(db.PendingRecipes, client.PendingRecipes.map(convertPendingRecipe));
     }
     if (client.TauntHistory !== undefined) {
-        anyKnownKey = true;
         db.TauntHistory = client.TauntHistory;
     }
     if (client.LoreFragmentScans !== undefined) {
-        anyKnownKey = true;
         db.LoreFragmentScans = client.LoreFragmentScans;
     }
     for (const key of ["PendingSpectreLoadouts", "SpectreLoadouts"] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             db[key] = client[key];
         }
     }
     if (client.FocusXP !== undefined) {
-        anyKnownKey = true;
         db.FocusXP = client.FocusXP;
     }
     for (const key of ["Alignment", "AlignmentReplay"] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             db[key] = client[key];
         }
     }
     if (client.StepSequencers !== undefined) {
-        anyKnownKey = true;
         db.StepSequencers = client.StepSequencers;
     }
     if (client.CompletedJobChains !== undefined) {
-        anyKnownKey = true;
         db.CompletedJobChains = client.CompletedJobChains;
     }
     if (client.Nemesis !== undefined) {
-        anyKnownKey = true;
         db.Nemesis = convertNemesis(client.Nemesis);
     }
     if (client.PlayerSkills !== undefined) {
-        anyKnownKey = true;
         db.PlayerSkills = client.PlayerSkills;
     }
     if (client.LotusCustomization !== undefined) {
-        anyKnownKey = true;
         db.LotusCustomization = convertItemConfig(client.LotusCustomization);
     }
     if (client.CollectibleSeries !== undefined) {
-        anyKnownKey = true;
         db.CollectibleSeries = client.CollectibleSeries;
     }
     for (const key of ["LibraryAvailableDailyTaskInfo", "LibraryActiveDailyTaskInfo"] as const) {
         if (client[key] !== undefined) {
-            anyKnownKey = true;
             db[key] = client[key];
         }
     }
     if (client.SongChallenges !== undefined) {
-        anyKnownKey = true;
         db.SongChallenges = client.SongChallenges;
     }
     if (client.Missions !== undefined) {
-        anyKnownKey = true;
         db.Missions = client.Missions;
     }
     if (client.FlavourItems !== undefined) {
-        anyKnownKey = true;
         db.FlavourItems.splice(0, db.FlavourItems.length);
         client.FlavourItems.forEach(x => {
             db.FlavourItems.push({
@@ -528,14 +487,11 @@ export const importInventory = (db: TInventoryDatabaseDocument, client: Partial<
         });
     }
     if (client.Accolades !== undefined) {
-        anyKnownKey = true;
         db.Accolades = client.Accolades;
     }
     if (client.Boosters !== undefined) {
-        anyKnownKey = true;
         replaceArray<IBooster>(db.Boosters, client.Boosters);
     }
-    return anyKnownKey;
 };
 
 export const importLoadOutConfig = (client: ILoadoutConfigClient): ILoadoutConfigDatabase => {