From d739945a1d81826d1134175ab6307ad0ac9ce925 Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Tue, 3 Jun 2025 10:40:28 -0700
Subject: [PATCH] fix: check that syndicateMissionId is not undefined (#2110)

Closes #2111

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/2110
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/services/missionInventoryUpdateService.ts | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts
index 7d8675c5..9c7dc93a 100644
--- a/src/services/missionInventoryUpdateService.ts
+++ b/src/services/missionInventoryUpdateService.ts
@@ -1207,7 +1207,9 @@ export const addMissionRewards = async (
         // eslint-disable-next-line @typescript-eslint/no-unused-vars
         const [jobType, unkIndex, hubNode, syndicateMissionId, locationTag] = rewardInfo.jobId.split("_");
         const syndicateMissions: ISyndicateMissionInfo[] = [];
-        pushClassicBounties(syndicateMissions, idToBountyCycle(syndicateMissionId));
+        if (syndicateMissionId) {
+            pushClassicBounties(syndicateMissions, idToBountyCycle(syndicateMissionId));
+        }
         const syndicateEntry = syndicateMissions.find(m => m._id.$oid === syndicateMissionId);
         if (syndicateEntry && syndicateEntry.Jobs) {
             let currentJob = syndicateEntry.Jobs[rewardInfo.JobTier!];
@@ -1556,7 +1558,9 @@ function getRandomMissionDrops(
                 let isEndlessJob = false;
                 if (syndicateMissionId) {
                     const syndicateMissions: ISyndicateMissionInfo[] = [];
-                    pushClassicBounties(syndicateMissions, idToBountyCycle(syndicateMissionId));
+                    if (syndicateMissionId) {
+                        pushClassicBounties(syndicateMissions, idToBountyCycle(syndicateMissionId));
+                    }
                     const syndicateEntry = syndicateMissions.find(m => m._id.$oid === syndicateMissionId);
                     if (syndicateEntry && syndicateEntry.Jobs) {
                         let job = syndicateEntry.Jobs[RewardInfo.JobTier!];