From 8f02bd150934e324855368001e1f542a8fc16409 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Sun, 1 Jun 2025 03:12:14 -0700 Subject: [PATCH] fix: avoid addition by undefined when adding skill points (#2108) Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/2108 Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com> Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com> --- src/services/missionInventoryUpdateService.ts | 4 ++-- src/types/requestTypes.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index 908be883..7d8675c5 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -326,8 +326,8 @@ export const addMissionInventoryUpdates = async ( break; } case "PlayerSkillGains": { - inventory.PlayerSkills.LPP_SPACE += value.LPP_SPACE; - inventory.PlayerSkills.LPP_DRIFTER += value.LPP_DRIFTER; + inventory.PlayerSkills.LPP_SPACE += value.LPP_SPACE ?? 0; + inventory.PlayerSkills.LPP_DRIFTER += value.LPP_DRIFTER ?? 0; break; } case "CustomMarkers": { diff --git a/src/types/requestTypes.ts b/src/types/requestTypes.ts index 6fdd0c09..a6b3f1c1 100644 --- a/src/types/requestTypes.ts +++ b/src/types/requestTypes.ts @@ -96,7 +96,7 @@ export type IMissionInventoryUpdateRequest = { FpsSamples: number; EvolutionProgress?: IEvolutionProgress[]; FocusXpIncreases?: number[]; - PlayerSkillGains: IPlayerSkills; + PlayerSkillGains: Partial; CustomMarkers?: ICustomMarkers[]; LoreFragmentScans?: ILoreFragmentScan[]; VoidTearParticipantsCurrWave?: {