From ab32728c47d2f22d956b18e29db3a5a371a9cab2 Mon Sep 17 00:00:00 2001 From: Sainan <63328889+Sainan@users.noreply.github.com> Date: Fri, 9 May 2025 21:36:49 -0700 Subject: [PATCH] fix: don't give assassination blueprint reward for archon hunt (#2031) Closes #2025 Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/2031 Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com> Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com> --- src/services/missionInventoryUpdateService.ts | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts index a585dceb3..a7172bf69 100644 --- a/src/services/missionInventoryUpdateService.ts +++ b/src/services/missionInventoryUpdateService.ts @@ -1372,20 +1372,16 @@ function getRandomMissionDrops( // TODO: Check that the invasion faction is indeed FC_INFESTATION once the Invasions in worldState are more dynamic rewardManifests = ["/Lotus/Types/Game/MissionDecks/BossMissionRewards/NyxRewards"]; } else if (RewardInfo.sortieId) { - // Sortie mission types differ from the underlying node and hence also don't give rewards from the underlying nodes. Assassinations are an exception to this. + // Sortie mission types differ from the underlying node and hence also don't give rewards from the underlying nodes. + // Assassinations in non-lite sorties are an exception to this. if (region.missionIndex == 0) { const arr = RewardInfo.sortieId.split("_"); - let sortieId = arr[1]; - if (sortieId == "Lite") { - sortieId = arr[2]; - } - const sortie = getSortie(idToDay(sortieId)); - const mission = sortie.Variants.find(x => x.node == arr[0])!; - if (mission.missionType == "MT_ASSASSINATION") { - rewardManifests = region.rewardManifests; - } else { - rewardManifests = []; + let giveNodeReward = false; + if (arr[1] != "Lite") { + const sortie = getSortie(idToDay(arr[1])); + giveNodeReward = sortie.Variants.find(x => x.node == arr[0])!.missionType == "MT_ASSASSINATION"; } + rewardManifests = giveNodeReward ? region.rewardManifests : []; } else { rewardManifests = []; }