From 203b3e20d9d94b4edeb244b355627e240aabe596 Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Tue, 6 May 2025 19:04:22 -0700
Subject: [PATCH] fix: refuse to give starting gear again (#1993)

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1993
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/services/inventoryService.ts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/services/inventoryService.ts b/src/services/inventoryService.ts
index c4d28edce..6a30df388 100644
--- a/src/services/inventoryService.ts
+++ b/src/services/inventoryService.ts
@@ -149,6 +149,11 @@ export const addStartingGear = async (
     inventory: TInventoryDatabaseDocument,
     startingGear?: TPartialStartingGear
 ): Promise<IInventoryChanges> => {
+    if (inventory.ReceivedStartingGear) {
+        throw new Error(`account has already received starting gear`);
+    }
+    inventory.ReceivedStartingGear = true;
+
     const { LongGuns, Pistols, Suits, Melee } = startingGear || {
         LongGuns: [{ ItemType: "/Lotus/Weapons/Tenno/Rifle/Rifle" }],
         Pistols: [{ ItemType: "/Lotus/Weapons/Tenno/Pistol/Pistol" }],
@@ -197,11 +202,6 @@ export const addStartingGear = async (
         combineInventoryChanges(inventoryChanges, inventoryDelta);
     }
 
-    if (inventory.ReceivedStartingGear) {
-        logger.warn(`account already had starting gear but asked for it again?!`);
-    }
-    inventory.ReceivedStartingGear = true;
-
     return inventoryChanges;
 };