chore: use updateOne for simple inventory field setters (#1211)

e.g. changing syndicate pledge now takes ~6 ms instead of ~84 ms.

Reviewed-on: OpenWF/SpaceNinjaServer#1211

src/controllers/api/addFriendImageController.ts

@@ -1,16 +1,25 @@
 import { RequestHandler } from "express";
 import { getJSONfromString } from "@/src/helpers/stringHelpers";
-import { IUpdateGlyphRequest } from "@/src/types/requestTypes";
 import { getAccountIdForRequest } from "@/src/services/loginService";
-import { getInventory } from "@/src/services/inventoryService";
+import { Inventory } from "@/src/models/inventoryModels/inventoryModel";
 
-const addFriendImageController: RequestHandler = async (req, res) => {
+export const addFriendImageController: RequestHandler = async (req, res) => {
     const accountId = await getAccountIdForRequest(req);
     const json = getJSONfromString<IUpdateGlyphRequest>(String(req.body));
-    const inventory = await getInventory(accountId);
+
-    inventory.ActiveAvatarImageType = json.AvatarImageType;
+    await Inventory.updateOne(
-    await inventory.save();
+        {
+            accountOwnerId: accountId
+        },
+        {
+            ActiveAvatarImageType: json.AvatarImageType
+        }
+    );
+
     res.json({});
 };
 
-export { addFriendImageController };
+interface IUpdateGlyphRequest {
+    AvatarImageType: string;
+    AvatarImage: string;
+}

src/controllers/api/setEquippedInstrumentController.ts

@@ -1,14 +1,21 @@
 import { RequestHandler } from "express";
 import { getAccountIdForRequest } from "@/src/services/loginService";
-import { getInventory } from "@/src/services/inventoryService";
 import { getJSONfromString } from "@/src/helpers/stringHelpers";
+import { Inventory } from "@/src/models/inventoryModels/inventoryModel";
 
 export const setEquippedInstrumentController: RequestHandler = async (req, res) => {
     const accountId = await getAccountIdForRequest(req);
-    const inventory = await getInventory(accountId);
     const body = getJSONfromString<ISetEquippedInstrumentRequest>(String(req.body));
-    inventory.EquippedInstrument = body.Instrument;
+
-    await inventory.save();
+    await Inventory.updateOne(
+        {
+            accountOwnerId: accountId
+        },
+        {
+            EquippedInstrument: body.Instrument
+        }
+    );
+
     res.end();
 };
 

src/controllers/api/setSupportedSyndicateController.ts

@@ -1,11 +1,18 @@
 import { RequestHandler } from "express";
 import { getAccountIdForRequest } from "@/src/services/loginService";
-import { getInventory } from "@/src/services/inventoryService";
+import { Inventory } from "@/src/models/inventoryModels/inventoryModel";
 
 export const setSupportedSyndicateController: RequestHandler = async (req, res) => {
     const accountId = await getAccountIdForRequest(req);
-    const inventory = await getInventory(accountId);
+
-    inventory.SupportedSyndicate = req.query.syndicate as string;
+    await Inventory.updateOne(
-    await inventory.save();
+        {
+            accountOwnerId: accountId
+        },
+        {
+            SupportedSyndicate: req.query.syndicate as string
+        }
+    );
+
     res.end();
 };

src/types/requestTypes.ts

@@ -132,10 +132,6 @@ export interface IRewardInfo {
 
 export type IMissionStatus = "GS_SUCCESS" | "GS_FAILURE" | "GS_DUMPED" | "GS_QUIT" | "GS_INTERRUPTED";
 
-export interface IUpdateGlyphRequest {
-    AvatarImageType: string;
-    AvatarImage: string;
-}
 export interface IUpgradesRequest {
     ItemCategory: TEquipmentKey;
     ItemId: IOid;