From 48eefd8db10689f3f09dd095e66069472c8bbe81 Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Sat, 26 Apr 2025 11:54:54 -0700
Subject: [PATCH] fix: don't give droptable rewards for non-assassination
 sortie missions (#1855)

Closes #1835

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/1855
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/services/missionInventoryUpdateService.ts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts
index 72813978..2283a819 100644
--- a/src/services/missionInventoryUpdateService.ts
+++ b/src/services/missionInventoryUpdateService.ts
@@ -1283,6 +1283,9 @@ function getRandomMissionDrops(
             // Invasion assassination has Phorid has the boss who should drop Nyx parts
             // TODO: Check that the invasion faction is indeed FC_INFESTATION once the Invasions in worldState are more dynamic
             rewardManifests = ["/Lotus/Types/Game/MissionDecks/BossMissionRewards/NyxRewards"];
+        } else if (RewardInfo.sortieId && region.missionIndex != 0) {
+            // Sortie mission types differ from the underlying node and hence also don't give rewards from the underlying nodes. Assassinations are an exception to this.
+            rewardManifests = [];
         } else {
             rewardManifests = region.rewardManifests;
         }