VampireKitten/SpaceNinjaServerOnlyGit
1
0
Fork 0
forked from OpenWF/SpaceNinjaServer
Code Pull Requests Activity

chore: don't validate Nonce in query (#1341)

Browse Source 
By asking MongoDB to simply find the account by the ID and then validating the nonce ourselves, we save roughly 1ms.

Reviewed-on: OpenWF/SpaceNinjaServer#1341
This commit is contained in:
Sainan 2025-03-27 03:33:27 -07:00
parent d9b944175a
commit a622393933
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/services/loginService.ts
View File

@ -74,11 +74,8 @@ export const getAccountForRequest = async (req: Request): Promise<TAccountDocume
throw new Error("Request is missing nonce parameter");
}
const account = await Account.findOne({
_id: req.query.accountId,
Nonce: nonce
});
if (!account) {
const account = await Account.findById(req.query.accountId);
if (!account || account.Nonce != nonce) {
throw new Error("Invalid accountId-nonce pair");
}
if (account.Dropped && req.query.ct) {