VampireKitten/SpaceNinjaServer-VampFork
1
0
Fork 0
forked from OpenWF/SpaceNinjaServer
Code Pull Requests Activity

chore: improve addMissionInventoryUpdates (#1121)

Browse Source 
Closes #1119

Reviewed-on: OpenWF/SpaceNinjaServer#1121
Co-authored-by: Sainan <sainan@calamity.inc>
Co-committed-by: Sainan <sainan@calamity.inc>
This commit is contained in:
Sainan 2025-03-08 06:29:05 -08:00 committed by OrdisPrime
parent 3853fda60d
commit 92d53e1c00
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/services/missionInventoryUpdateService.ts
View File

@ -65,12 +65,8 @@ const getRandomRewardByChance = (pool: IReward[]): IRngResult | undefined => {
export const addMissionInventoryUpdates = async ( export const addMissionInventoryUpdates = async (
inventory: HydratedDocument<IInventoryDatabase, InventoryDocumentProps>, inventory: HydratedDocument<IInventoryDatabase, InventoryDocumentProps>,
inventoryUpdates: IMissionInventoryUpdateRequest inventoryUpdates: IMissionInventoryUpdateRequest
): Promise<Partial<IInventoryDatabase> | undefined> => { ): Promise<IInventoryChanges> => {
//TODO: type this properly const inventoryChanges: IInventoryChanges = {};
const inventoryChanges: Partial<IInventoryDatabase> = {};
if (inventoryUpdates.MissionFailed === true) {
return;
}
if (inventoryUpdates.RewardInfo && inventoryUpdates.RewardInfo.periodicMissionTag) { if (inventoryUpdates.RewardInfo && inventoryUpdates.RewardInfo.periodicMissionTag) {
const tag = inventoryUpdates.RewardInfo.periodicMissionTag; const tag = inventoryUpdates.RewardInfo.periodicMissionTag;
const existingCompletion = inventory.PeriodicMissionCompletions.find(completion => completion.tag === tag); const existingCompletion = inventory.PeriodicMissionCompletions.find(completion => completion.tag === tag);