Slayer55555/SpaceNinjaServer
1
0
Fork 0
forked from OpenWF/SpaceNinjaServer
Code Pull Requests Activity

fix: only commit 'Missions' on successful completion (#2866)

Browse Source 
Fixes SP missions being marked as completed when failing/quitting.

Reviewed-on: OpenWF/SpaceNinjaServer#2866
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
This commit is contained in:
Sainan 2025-10-06 22:57:18 -07:00 committed by Sainan
parent 30f380f37e
commit f5c1b83598
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/services/missionInventoryUpdateService.ts
View File

@ -309,9 +309,6 @@ export const addMissionInventoryUpdates = async (
} }
break; break;
} }
case "Missions":
addMissionComplete(inventory, value);
break;
case "LastRegionPlayed": case "LastRegionPlayed":
if (!(config.unfaithfulBugFixes?.ignore1999LastRegionPlayed && value === "1999MapName")) { if (!(config.unfaithfulBugFixes?.ignore1999LastRegionPlayed && value === "1999MapName")) {
inventory.LastRegionPlayed = value; inventory.LastRegionPlayed = value;
@ -1208,6 +1205,9 @@ export const addMissionRewards = async (
if (missions && missions.Tag in ExportRegions) { if (missions && missions.Tag in ExportRegions) {
const node = ExportRegions[missions.Tag]; const node = ExportRegions[missions.Tag];
// cannot add this with normal updates because { Tier: 1 } would mark the SP node as completed even on a failure
addMissionComplete(inventory, missions);
//node based credit rewards for mission completion //node based credit rewards for mission completion
if (isEligibleForCreditReward(rewardInfo, missions, node)) { if (isEligibleForCreditReward(rewardInfo, missions, node)) {
const levelCreditReward = getLevelCreditRewards(node); const levelCreditReward = getLevelCreditRewards(node);