From f5c1b8359895df5966c50d9a6aac733b22c25450 Mon Sep 17 00:00:00 2001
From: Sainan <63328889+Sainan@users.noreply.github.com>
Date: Mon, 6 Oct 2025 22:57:18 -0700
Subject: [PATCH] fix: only commit 'Missions' on successful completion (#2866)

Fixes SP missions being marked as completed when failing/quitting.

Reviewed-on: https://onlyg.it/OpenWF/SpaceNinjaServer/pulls/2866
Co-authored-by: Sainan <63328889+Sainan@users.noreply.github.com>
Co-committed-by: Sainan <63328889+Sainan@users.noreply.github.com>
---
 src/services/missionInventoryUpdateService.ts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/services/missionInventoryUpdateService.ts b/src/services/missionInventoryUpdateService.ts
index dfb6c815..eb586eee 100644
--- a/src/services/missionInventoryUpdateService.ts
+++ b/src/services/missionInventoryUpdateService.ts
@@ -309,9 +309,6 @@ export const addMissionInventoryUpdates = async (
                 }
                 break;
             }
-            case "Missions":
-                addMissionComplete(inventory, value);
-                break;
             case "LastRegionPlayed":
                 if (!(config.unfaithfulBugFixes?.ignore1999LastRegionPlayed && value === "1999MapName")) {
                     inventory.LastRegionPlayed = value;
@@ -1208,6 +1205,9 @@ export const addMissionRewards = async (
     if (missions && missions.Tag in ExportRegions) {
         const node = ExportRegions[missions.Tag];
 
+        // cannot add this with normal updates because { Tier: 1 } would mark the SP node as completed even on a failure
+        addMissionComplete(inventory, missions);
+
         //node based credit rewards for mission completion
         if (isEligibleForCreditReward(rewardInfo, missions, node)) {
             const levelCreditReward = getLevelCreditRewards(node);